Skip to content

Conversation

jameshurst
Copy link
Contributor

I've added the ability to handle an escape character when the control is a single Character in length.

I've also added a value to Special.strings to make sure that the parser won't fall back to interpreting the file as an NSDictionary. This tests for a case where previously the parser would complete successfully, but drop the quoted value. A value such as \"http://\" or \"https://\" would be parsed as [.key("quoted"), .equal, .value("\\"), .message("\\\" or \\\"https://\\\"\";")] due to the parser encountering a // and attempting to read a comment. Since values don't get added to the results until a semicolon is encountered, it would cause the quoted string to be dropped.

@igorkulman igorkulman self-assigned this Feb 20, 2020
@igorkulman igorkulman added the bug Something isn't working label Feb 20, 2020
Copy link
Owner

@igorkulman igorkulman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@igorkulman igorkulman merged commit 527f55e into igorkulman:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants