fix(pdf): For monospaced text, Add Noto Sans Mono before NOTO_SYMBOLS #1261
Conversation
This is an attempt to address ietf-tools#1245
|
The idea here is to keep in the Roboto and Noto families, but to increase the range of covered glyphs in a fixed-width font. I'm not sure how well this will work, because i don't think i have the same font environment that the RFC editor's toolchain uses when it works. but hopefully this makes it easier to test, at least. |
|
This is a better solution and this change stops leaking non-RFC fonts. |
|
@dkg If you want to use the same fonts as RFC editor, you can get them from xml2rfc-fonts or you xml2rfc docker instace with |
xml2rfc/writers/pdf.py
Outdated
| @@ -133,10 +133,12 @@ def get_mono_fonts(self): | |||
| fonts = set() | |||
| scripts = self.root.get('scripts').split(',') | |||
| roboto_mono = "Roboto Mono" | |||
| noto_sans_mono = "Noto Sans Mono" | |||
| dejavu_sans_mono = "DejaVu Sans Mono" | |||
There was a problem hiding this comment.
PDFs have been restricted to Noto and Roboto Mono fonts.
I guess this needs attention of rapt/rswg.
|
OK, how about just merging the first patch of this series (since it's just Roboto and Noto), and then we can pursue one of the other resolution strategies discussed in #1245? |
|
I've dropped the commit from this series that included DejaVu Sans Mono, to focus specifically on Noto Sans Mono, as it should be sufficient for a BOX-DRAWINGS-only resolution to the specific issues. Maybe this is safe to merge as-is now, regardless of the outcome of the rpat discussion? I can always open up a separate MR for further discussion related to DejaVu Sans Mono. |
This is an attempt to address #1245