fix: add prefix to call to compareCommitsWithBasehead #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to resolve issue ietf-tools#31
NGPixel
requested changes
Nov 11, 2023
index.js
Outdated
| @@ -4,7 +4,7 @@ const _ = require('lodash') | |||
| const cc = require('@conventional-commits/parser') | |||
| const semver = require('semver') | |||
|
|
|||
| async function main () { | |||
| async function main() { | |||
There was a problem hiding this comment.
Don't change the code existing formatting, which follows Standard JS. Same for line 26.
There was a problem hiding this comment.
Sorry about that -- I didn't mean to change that. My editor did it automatically :). Should be back to the way it was.
There was a problem hiding this comment.
@NGPixel Ah, oops. Forgot the build step ... hold on a minute.
There was a problem hiding this comment.
@NGPixel Fixed now.
dfef8c4 to
c18711a
Compare
NGPixel
approved these changes
Nov 12, 2023
|
Thanks! |
|
@NGPixel Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve issue #31.
This adds ${prefix} into the call to compareCommitsWithBasehead.