chore: finish dropping smtpd #9384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjsparks
approved these changes
Aug 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of the last uses of the deprecated smtpd library, which was providing the debugging server that echoed messages to the dev console. The supported aiosmtpd library has an equivalent command-line debug mode. Because of #8806, a custom handler is added just to set the line length limit to something that works. (Without this, e.g., a password reset email is rejected by the debug server.)
Also renames the
test_smtpserver.pymodule to something that makes more sense to me and is less likely to be confused for a set of test cases.