fix: escape nulls in XML api responses #9283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Less likely to lead to null injection down the road
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9283 +/- ##
==========================================
- Coverage 88.74% 88.74% -0.01%
==========================================
Files 320 320
Lines 41674 41685 +11
==========================================
+ Hits 36985 36992 +7
- Misses 4689 4693 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjsparks
approved these changes
Aug 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces null characters with
\0in tastypie XML responses. This should stanch the flow of 500 errors we get when fuzzers hit tastypie endpoints. (Tastypie is correctly rejecting the requests with the garbage, then hitting an exception when it tries to respond with an XML format error that includes the garbage, so these errors are pure noise.)