fix: improve pw validation without js #9113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only used for password reset
This form class hierarchy reallllly needs to be refactored more deeply
kesara
reviewed
Jul 9, 2025
kesara
reviewed
Jul 9, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9113 +/- ##
==========================================
- Coverage 88.75% 88.73% -0.02%
==========================================
Files 321 321
Lines 41851 41853 +2
==========================================
- Hits 37143 37140 -3
- Misses 4708 4713 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjsparks
approved these changes
Jul 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with poor / absent feedback about rejected passwords when passwords are reset, changed, or initially created in a browser with javascript disabled.
It's tempting to go on a deeper dive refactoring the password forms, but I think this is a sensible stopping point. This will need more serious work when we move to an external auth system and/or migrate to Django 5.