Skip to content

fix: remove liaison_contact and liaison_cc_contact Role objects #8920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

rjsparks
Copy link
Member

No description provided.

@rjsparks rjsparks marked this pull request as draft May 23, 2025 21:08
@rjsparks
Copy link
Member Author

rjsparks commented May 23, 2025

cc: @mirjak (focus on migratiaon 0006 (i.e. bdd4962), the commit with 0005 is only here at the moment to promote expedient review)

Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.80%. Comparing base (97c9eeb) to head (bdd4962).
Report is 24 commits behind head on feat/liaisons.

Additional details and impacted files
@@              Coverage Diff               @@
##           feat/liaisons    #8920   +/-   ##
==============================================
  Coverage          88.80%   88.80%           
==============================================
  Files                314      314           
  Lines              41419    41419           
==============================================
  Hits               36782    36782           
  Misses              4637     4637           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jennifer-richards jennifer-richards changed the base branch from main to feat/liaisons May 26, 2025 14:19
@jennifer-richards
Copy link
Member

cc: @mirjak (focus on migratiaon 0006 (i.e. bdd4962), the commit with 0005 is only here at the moment to promote expedient review)

n.b., the other PR has been merged so this comment is stale - the 0005 migration Robert referred to no longer shows up in the diff for this PR.

@rjsparks rjsparks marked this pull request as ready for review May 27, 2025 13:21
@jennifer-richards jennifer-richards merged commit 432c50e into ietf-tools:feat/liaisons May 27, 2025
10 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2025
@rjsparks rjsparks deleted the roleawaymore branch June 6, 2025 15:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants