fix: remove credentials omit from agenda fetch call #8779
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the fetch call for agenda data by removing the unnecessary credentials option, streamlining the API request.
- Removed "credentials: 'omit'" from the fetch call.
- Simplified the request to better align with the API's expected behavior.
There was a problem hiding this comment.
Wonder if it should be 'same-origin' to reduce risk of CSRF issues if the code gets reused?
https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch#including_credentials
edit: never mind, I see that's the default if I actually read my own reference 😬
|
From discussion - instead of this PR we probably want to either change the code to make production and staging behave differently, or change the CF rules around the api endpoint at staging instead. If we want to do that in this code, please update this PR, otherwise close it. |
|
Subsequent discussion convinced me I was incorrect above. |
No description provided.