Skip to content

Conversation

bkmgit
Copy link
Contributor

@bkmgit bkmgit commented Mar 15, 2025

No description provided.

@bkmgit
Copy link
Contributor Author

bkmgit commented Mar 15, 2025

fixes #8424 by using the suggested text in the issue.

Copy link

codecov bot commented Mar 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.80%. Comparing base (70bf2ae) to head (2be0c02).
Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8670      +/-   ##
==========================================
- Coverage   88.88%   88.80%   -0.08%     
==========================================
  Files         312      314       +2     
  Lines       40891    41221     +330     
==========================================
+ Hits        36345    36606     +261     
- Misses       4546     4615      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rjsparks
Copy link
Member

cc: @rdanyliw

Copy link
Member

@rjsparks rjsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some repetition of the conditionals in the template that would be better handled as nested conditionals, but we'll improve it with a separate effort.

@rjsparks rjsparks merged commit 37b4448 into ietf-tools:main Mar 21, 2025
10 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants