Skip to content

Conversation

richsalz
Copy link
Collaborator

Fixes: #7866

Copy link

codecov bot commented Mar 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.80%. Comparing base (70bf2ae) to head (25ffdd7).
Report is 42 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8676      +/-   ##
==========================================
- Coverage   88.88%   88.80%   -0.08%     
==========================================
  Files         312      314       +2     
  Lines       40891    41243     +352     
==========================================
+ Hits        36345    36626     +281     
- Misses       4546     4617      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@rjsparks rjsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit:

@rjsparks
Copy link
Member

I think I can simplify this - if so, will commit that simplification in a bit

@rjsparks
Copy link
Member

And on further review - the PR missed the aim of the issue - the issue was asking for the title of the draft, not the name.

@richsalz
Copy link
Collaborator Author

And on further review - the PR missed the aim of the issue - the issue was asking for the title of the draft, not the name.

Aargh. I blame jet-lag. :)

@rjsparks rjsparks merged commit fde8136 into ietf-tools:main Mar 19, 2025
10 checks passed
@pspacek
Copy link

pspacek commented Mar 19, 2025

Thank you very much!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add draft title in beginning of review email message
4 participants