Skip to content

#3427 - Treat manifest warnings as warnings #3429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 16, 2023
Merged

#3427 - Treat manifest warnings as warnings #3429

merged 2 commits into from
Nov 16, 2023

Conversation

iBotPeaches
Copy link
Owner

@iBotPeaches iBotPeaches commented Nov 16, 2023 •
edited
Loading 

// Whether validation errors should be treated only as warnings. If this is 'true', then an
// incorrect node will not result in an error, but only as a warning, and the parsing will
// continue.
bool warn_validation = false;

Missed this during aapt2 addition. We should have aapt2 in the least strict mode possible as we are rebuilding apps and shouldn't be binded by the latest in build-time enforcement from aapt2.

Fixes: #3427

@iBotPeaches iBotPeaches added this to the v2.9.1 milestone Nov 16, 2023
@iBotPeaches iBotPeaches merged commit 72d0bc1 into master Nov 16, 2023
@iBotPeaches iBotPeaches deleted the issue-3427 branch November 16, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
aapt/aapt2
Projects
None yet
Milestone
v2.9.1
Development

Successfully merging this pull request may close these issues.

[BUG] Unexpected element found in manifest
1 participant
@iBotPeaches