Skip to content

Implement fixes proposed by @liamcain (@obsidianmd) #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2023
Merged

Implement fixes proposed by @liamcain (@obsidianmd) #30

merged 1 commit into from
Jan 24, 2023

Conversation

p-l-
Copy link
Member

@p-l- p-l- commented Jan 24, 2023 •
edited
Loading

Based from @liamcain on comment in obsidianmd/obsidian-releases#1490:

  • Remove out-of-scope this.app
  • Validate getActiveFile() return value
  • Remove the "ivre-" prefix from the command name

@p-l-
Implement fixes proposed by @liamcain (@obsidianmd)
75a9ce9 
Based on comment in obsidianmd/obsidian-releases#1490:

- Remove out-of-scope `this.app`
- Validate `getActiveFile()` return value
- Remove the "ivre-" prefix from the command name
@p-l- p-l- merged commit 5bbc490 into ivre:master Jan 24, 2023
@p-l- p-l- deleted the fixes-obsidian branch January 24, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@p-l-