Fixed off-by-one in handling of drive P: in CLI args. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command-line interface allows the specification of local directories to be used as CP/M drives. I accidentally noticed that the final drive is not specified as expected because I happen to have a P-drive setup for Turbo-Pascal: ``` $ ./target/debug/iz-cpm --disk-p /home/skx/Repos/github.com/skx/cpm-dist/P iz-cpm https://github.com/ivanizag/iz-cpm CP/M 2.2 Emulation Press ctrl-c ctrl-c Y to return to host A>p: P>dir Bdos Err On P: Bad Sector No File ``` There is a loop setup which runs from 0-15, but it excludes the last value. This PR updates to use 0-16, so that drive 15 (P:) is included.
|
You are right. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command-line interface allows the specification of local directories to be used as CP/M drives.
I accidentally noticed that the final drive is not specified as expected because I happen to have a P-drive setup for Turbo-Pascal:
There is a loop setup which runs from 0-15, but it excludes the last value. This PR updates to use 0-16, so that drive 15 (P:) is included.