Skip to content

Update sp layout #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 28, 2024
Merged

Update sp layout #3

merged 2 commits into from
Jul 28, 2024

Conversation

ZYHowell
Copy link
Collaborator

This PR makes the layout of Sequence parallel only adds padding tokens at the end of the last sp rank, and is after each request instead of at the end of all requests

@ZYHowell ZYHowell requested a review from ivanium July 24, 2024 08:15
@ivanium ivanium mentioned this pull request Jul 26, 2024
Merged
ivanium
ivanium approved these changes Jul 28, 2024
View reviewed changes
Copy link
Owner

@ivanium ivanium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried this PR and tested it in my local branch #2 and it looks correct. So I think we can get this merged first before merging the sp attn kernel.

@ZYHowell ZYHowell merged commit 4b8203a into main Jul 28, 2024
@ZYHowell ZYHowell deleted the pr-new-sp-layout branch July 28, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanium ivanium ivanium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZYHowell @ivanium