(fix) site_cache_dir() must return DVC_SITE_CACHE_DIR if it exists
#10776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10776 +/- ##
==========================================
+ Coverage 90.68% 91.05% +0.36%
==========================================
Files 504 504
Lines 39795 40007 +212
Branches 3141 3161 +20
==========================================
+ Hits 36087 36427 +340
+ Misses 3042 2951 -91
+ Partials 666 629 -37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skshetry
approved these changes
Jun 12, 2025
|
@rgoya, Thank you for contributing! |
👍 This had me scratching my head, it was working on my Macos laptop, but breaking in our CI pipeline ( (Also, I have a related follow up bug and fix coming up) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10775
There was a regression introduced in #10603 where, when dealing with a change of behaviour in
platformdirs, the fix effectively caused Linux (Unix) systems to ignore theDVC_SITE_CACHE_DIRenvironment variable.This PR ensures that
site_cache_dir()returns value of theDVC_SITE_CACHE_DIRvariable is returned if it exists, and deals with theplatformdirsissues if not.❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏