Update pre-commit to use pinned version of dvc and correct stage names
#10621
+7
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pre-commit` [changed the acceptable stage names](https://pre-commit.com/#confining-hooks-to-run-at-certain-stages)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10621 +/- ##
==========================================
+ Coverage 90.68% 91.01% +0.32%
==========================================
Files 504 504
Lines 39795 39797 +2
Branches 3141 3141
==========================================
+ Hits 36087 36220 +133
+ Misses 3042 2948 -94
+ Partials 666 629 -37 ☔ View full report in Codecov by Sentry. |
|
thanks @mkdjr ! Is it still in draft, needs more testing? |
|
Oh yeah, I forgot to take it out of its drafted state. I think it's good to go, but should probably be followed up with a future PR to automate updating the |
skshetry
reviewed
Nov 15, 2024
Co-authored-by: skshetry <18718008+skshetry@users.noreply.github.com>
for more information, see https://pre-commit.ci
skshetry
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
1. Pin
revargument inpre-commit-config.yamlwriterThe
pre-commitpackage recommends against using mutable references such asmain, as the version of the package pulled in the hook (in this casedvc), does not get updated after the first timepre-commitinstalls it. This PR addresses this by instead pinning the hooks todvcv3.56.0. This change is made with the goal of:pre-commitwarning, anddvcversion thatpre-commitrefers to whendvcreceives a new release.As a reference,
ruff, the python linter and formatter, keeps its pre-commit hooks in a separate repository. This repository has its own pre-commit hooks that automatically pull the latest version ofruffand updates the version pointer in thepre-commit-hooks.yamlfile. Maybedvccould do something like this in the future to automate thepre-commit-hooks.yamlupdate process.2. Update
stageskeywordsAdditionally,
pre-commithas now deprecated the acceptable values for thestageskeyword forhooks. I have updated thedvc installcommand and thepre-commit-hooks.yamlfile to reflect this change.As this change was made in
pre-commitv3.2.0, thedvchooks now requirepre-committo be updated to at least v3.2.0.Closes #9897.
Associated documentation PR: iterative/dvc.org#5323.