import: fix broken progressbar when importing folder #10678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrchmelar
commented
Jan 28, 2025
skshetry
approved these changes
Jan 28, 2025
Add child progress bar to dvc fs to report directory import progress correctly. Fixes iterative#10677
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10678 +/- ##
==========================================
+ Coverage 90.68% 91.07% +0.38%
==========================================
Files 504 504
Lines 39795 39930 +135
Branches 3141 3157 +16
==========================================
+ Hits 36087 36365 +278
+ Misses 3042 2938 -104
+ Partials 666 627 -39 ☔ View full report in Codecov by Sentry. |
|
Thank you, @petrchmelar for the contributions. I made one minor adjustment to your PR on how I also found a small bug that was fixed in iterative/dvc-data#596. Single vs multiple progress bars can be tackled separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add child progress bar to dvc fs to report directory import progress correctly.
Fixes #10677
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏