Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: iterative/dvc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3.57.0
Choose a base ref
...
head repository: iterative/dvc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3.58.0
Choose a head ref
  • 3 commits
  • 7 files changed
  • 3 contributors

Commits on Nov 29, 2024

  1. Configuration menu
    Copy the full SHA
    64ccd9c View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2024

  1. Fix #10593 -- add --keep option for dvc experiments remove (#10633)

    * Add keep_selected parameter, and corresponding code to keep only the selected exps (and remove all the other ones)
    
    * test keep_selected_by_name
    
    * test keep_selected_by_rev
    
    * test keep_selected multiple, by name
    
    * test keep all by name
    
    * test keep by rev, with num=2
    
    * added option to cli
    
    * refactoring to meet pr needs
    
    * [pre-commit.ci] auto fixes from pre-commit.com hooks
    
    for more information, see https://pre-commit.ci
    
    * fixed test_experiments to add keep_selected=False to remove tests
    
    * rename parameter to match cli option
    
    * follow the normal path, then invert the selection before removing
    
    * fixed tests for list ordering + fixed test with non existent name, it didn't make sense to delete everything if an exp name did not exist
    
    * changed cli option comment
    
    * [pre-commit.ci] auto fixes from pre-commit.com hooks
    
    for more information, see https://pre-commit.ci
    
    * fixed typing issue
    
    * updated parameter name
    
    * removed handling queued experiments (since --queue would remove them all)
    
    * [pre-commit.ci] auto fixes from pre-commit.com hooks
    
    for more information, see https://pre-commit.ci
    
    * code simplification, added __eq__ and __hash__ to be able to compare ExpRefs, updated and parametrized tests.
    
    * [pre-commit.ci] auto fixes from pre-commit.com hooks
    
    for more information, see https://pre-commit.ci
    
    * fixed linting issues
    
    * - --keep and --queue together raise an InvalidArgumentError
        - added a test to check if the error is raised
        - fixed CLI message
    
    * [pre-commit.ci] auto fixes from pre-commit.com hooks
    
    for more information, see https://pre-commit.ci
    
    * re-run gh tests. Some tests which did not involve my changes started failing while they were passing fine before.
    
    ---------
    
    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    rmic and pre-commit-ci[bot] authored Nov 30, 2024
    Configuration menu
    Copy the full SHA
    368c785 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2024

  1. Fix #10638 : makes remove return correct list when used with both `--…

    …queue` and `-A` (#10641)
    
    * fixed a bug where using both `--queue` and `-A` would yield a "removed" list without the queued experiments
    
    * added a test to validate the fix
    
    * [pre-commit.ci] auto fixes from pre-commit.com hooks
    
    for more information, see https://pre-commit.ci
    
    * clearer name for test
    
    ---------
    
    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    rmic and pre-commit-ci[bot] authored Dec 1, 2024
    Configuration menu
    Copy the full SHA
    198c8f2 View commit details
    Browse the repository at this point in the history
Loading