Skip to content

Bump version to v0.19.0 #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Bump version to v0.19.0 #1352

wants to merge 2 commits into from

Conversation

casperdcl
Copy link
Contributor

Approve me 🤖

@casperdcl casperdcl temporarily deployed to internal February 13, 2023 21:43 — with GitHub Actions Inactive
@casperdcl casperdcl enabled auto-merge (squash) February 13, 2023 21:43
0x2b3bfa0
0x2b3bfa0 approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖

@casperdcl casperdcl marked this pull request as draft February 13, 2023 21:44
auto-merge was automatically disabled February 13, 2023 21:44

Pull request was converted to draft

@casperdcl
Copy link
Contributor Author

ack nvm, forgot about v0.major.minor not v0.minor.patch

@casperdcl casperdcl closed this Feb 13, 2023
@github-actions
Copy link
Contributor

Test Comment

@github-actions
Copy link
Contributor

Test Comment

@0x2b3bfa0
Copy link
Member

What's that v0.major.minor aberration? 🤔 We [are supposed to] follow semantic versioning, and bumping the minor version is fine when introducing new features.

@casperdcl
Copy link
Contributor Author

afaik https://semver.org/ has specific exceptions for 0.y.z, TL;DR treating it more like 0.major.minor

@casperdcl casperdcl mentioned this pull request Feb 13, 2023
Merged
@0x2b3bfa0 0x2b3bfa0 deleted the bump/v0.19.0 branch June 4, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casperdcl @0x2b3bfa0