Skip to content

Improve error message #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 14, 2023
Merged

Improve error message #1349

merged 5 commits into from
Feb 14, 2023

Conversation

balazspeczeli
Copy link
Contributor

Please see diff.

@balazspeczeli balazspeczeli temporarily deployed to external February 11, 2023 21:12 — with GitHub Actions Inactive
dacbd
dacbd approved these changes Feb 11, 2023
View reviewed changes
Copy link
Contributor

@dacbd dacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple, please feel free to spot any others.

@dacbd dacbd added the technical-debt Refactoring, linting & tidying label Feb 11, 2023
@dacbd dacbd enabled auto-merge (squash) February 11, 2023 21:18
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
dacbd
dacbd suggested changes Feb 12, 2023
View reviewed changes
@dacbd dacbd temporarily deployed to external February 12, 2023 00:42 — with GitHub Actions Inactive
@dacbd dacbd self-requested a review February 12, 2023 00:45
dacbd
dacbd previously approved these changes Feb 12, 2023
View reviewed changes
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@dacbd
Copy link
Contributor

dacbd commented Feb 13, 2023

@balazspeczeli please run npm run lintfix and I can merge this.

auto-merge was automatically disabled February 13, 2023 23:26

Head branch was pushed to by a user without write access

@balazspeczeli balazspeczeli temporarily deployed to external February 13, 2023 23:26 — with GitHub Actions Inactive
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@dacbd dacbd temporarily deployed to external February 14, 2023 15:18 — with GitHub Actions Inactive
@dacbd dacbd enabled auto-merge (squash) February 14, 2023 15:18
@github-actions
Copy link
Contributor

Test Comment

@github-actions
Copy link
Contributor

Test Comment

@dacbd dacbd merged commit 1f6068d into iterative:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasdomas tasdomas tasdomas approved these changes

@dacbd dacbd dacbd left review comments

Assignees

@balazspeczeli balazspeczeli

Labels
technical-debt Refactoring, linting & tidying
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balazspeczeli @dacbd @tasdomas