Skip to content

add runner --reuse-idle #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 30, 2022
Merged

add runner --reuse-idle #1070

merged 13 commits into from
Jun 30, 2022

Conversation

dacbd
Copy link
Contributor

@dacbd dacbd commented Jun 20, 2022 •
edited
Loading

Closes: #575
Test
Usage

@dacbd dacbd temporarily deployed to internal June 20, 2022 17:00 Inactive
@dacbd dacbd temporarily deployed to internal June 20, 2022 17:01 Inactive
@dacbd dacbd temporarily deployed to internal June 20, 2022 17:08 Inactive
@dacbd
Copy link
Contributor Author

dacbd commented Jun 20, 2022 •
edited
Loading

  • test GitLab

but since the current --reuse mechanics are essentially the same I think that it is ready for review

@dacbd dacbd marked this pull request as ready for review June 20, 2022 17:12
@dacbd dacbd added the cml-runner Subcommand label Jun 20, 2022
@dacbd dacbd self-assigned this Jun 20, 2022
@dacbd dacbd mentioned this pull request Jun 20, 2022
Merged
1 task
@dacbd dacbd requested a review from a team June 20, 2022 17:47
0x2b3bfa0
0x2b3bfa0 reviewed Jun 21, 2022
View reviewed changes
@dacbd dacbd temporarily deployed to internal June 21, 2022 01:50 Inactive
DavidGOrtega
DavidGOrtega suggested changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@DavidGOrtega DavidGOrtega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To accept this PR we have to simulate the busy state of the runner in BB and GL.
The only way to to it is to get all the active jobs and check if they belong to the runner.
It can be done at least in Gitlab

@dacbd dacbd temporarily deployed to internal June 21, 2022 15:38 Inactive
@dacbd dacbd temporarily deployed to internal June 21, 2022 16:00 Inactive
@dacbd dacbd requested a review from DavidGOrtega June 21, 2022 16:25
@casperdcl
Copy link
Contributor

can always add BitBucket to https://github.com/iterative/cml/wiki/Backend-Supported-Features for now :)

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 24, 2022 10:39 Inactive
DavidGOrtega
DavidGOrtega approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@DavidGOrtega DavidGOrtega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Nitpick: throw

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 29, 2022 15:19 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal June 29, 2022 18:25 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal June 30, 2022 16:18 Inactive
@DavidGOrtega DavidGOrtega merged commit b4c7898 into master Jun 30, 2022
@DavidGOrtega DavidGOrtega deleted the reuse-runners branch June 30, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 left review comments

+1 more reviewer

@DavidGOrtega DavidGOrtega DavidGOrtega approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@dacbd dacbd

Labels
cml-runner Subcommand
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cml-runner: Add an option to reuse only idle runners
4 participants
@dacbd @casperdcl @DavidGOrtega @0x2b3bfa0