Skip to content

Target Specific CML version on created instance. #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 10, 2022
Merged

Target Specific CML version on created instance. #905

merged 5 commits into from
Mar 10, 2022

Conversation

dacbd
Copy link
Contributor

@dacbd dacbd commented Mar 1, 2022

The default should be the same as the invoking CML version or unset.
Option hidden as this value probably shouldn't be set 98%

@dacbd dacbd temporarily deployed to external March 1, 2022 17:58 Inactive
@dacbd
Copy link
Contributor Author

dacbd commented Mar 1, 2022

An Example of the convenience factor this could provide; testing #689 against #808 in a live setting if I could get it to happen twice 🔍

@0x2b3bfa0 0x2b3bfa0 requested a review from a team March 1, 2022 18:57
@casperdcl casperdcl added the testing Unit tests & debugging label Mar 1, 2022
casperdcl
casperdcl reviewed Mar 1, 2022
View reviewed changes
0x2b3bfa0
0x2b3bfa0 reviewed Mar 1, 2022
View reviewed changes
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to external March 1, 2022 21:58 Inactive
@0x2b3bfa0
Copy link
Member

Looks great! @dacbd, can you please include this option in terraform.test.js snapshot tests and update them?

@dacbd
Copy link
Contributor Author

dacbd commented Mar 2, 2022 via email

@dacbd dacbd temporarily deployed to external March 4, 2022 19:05 Inactive
@dacbd
Copy link
Contributor Author

dacbd commented Mar 6, 2022

This test failure looks to be unrelated to any of the changes? https://github.com/iterative/cml/runs/5428037240?check_suite_focus=true#step:7:81

@dacbd dacbd temporarily deployed to external March 6, 2022 19:09 Inactive
@0x2b3bfa0
Copy link
Member

Yes, it looks like our tests are broken (?) 🔔 @iterative/cml

@casperdcl
Copy link
Contributor

Looks like GL token length change from 20 to 29?

@DavidGOrtega
Copy link
Contributor

Yes. Its something that I also saw in #689

@DavidGOrtega
Copy link
Contributor

@dacbd

cml/src/drivers/gitlab.test.js

Line 43 in 266e612

expect(output.length >= 20).toBe(true);

@dacbd dacbd temporarily deployed to external March 9, 2022 16:10 Inactive
@dacbd
Copy link
Contributor Author

dacbd commented Mar 9, 2022

@dacbd

cml/src/drivers/gitlab.test.js

Line 43 in 266e612

expect(output.length >= 20).toBe(true);

thanks, cherry-picked over.

@dacbd dacbd temporarily deployed to external March 9, 2022 19:23 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to external March 10, 2022 08:39 Inactive
@DavidGOrtega DavidGOrtega merged commit e76611f into iterative:master Mar 10, 2022
@DavidGOrtega
Copy link
Contributor

Thanks @dacbd !!! ❤️

@0x2b3bfa0
Copy link
Member

Ditto! ❤️

@casperdcl casperdcl mentioned this pull request Mar 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 left review comments

+1 more reviewer

@casperdcl casperdcl casperdcl approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@dacbd dacbd

Labels
testing Unit tests & debugging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dacbd @0x2b3bfa0 @casperdcl @DavidGOrtega