Skip to content

Runner docker volumes #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jan 21, 2022
Merged

Runner docker volumes #861

merged 24 commits into from
Jan 21, 2022

Conversation

DavidGOrtega
Copy link
Contributor

@DavidGOrtega DavidGOrtega commented Jan 6, 2022 •
edited
Loading

Usage

cml runner --repo XXX --token XXX  --docker-volumes /test:/test --docker-volumes /test:/testb

@DavidGOrtega DavidGOrtega temporarily deployed to internal January 6, 2022 18:05 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal January 6, 2022 18:20 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal January 6, 2022 18:23 Inactive
@DavidGOrtega DavidGOrtega marked this pull request as draft January 6, 2022 18:24
casperdcl
casperdcl reviewed Jan 6, 2022
View reviewed changes
casperdcl
casperdcl reviewed Jan 6, 2022
View reviewed changes
@DavidGOrtega DavidGOrtega temporarily deployed to internal January 6, 2022 18:36 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal January 6, 2022 18:54 Inactive
0x2b3bfa0
0x2b3bfa0 reviewed Jan 6, 2022
View reviewed changes
0x2b3bfa0
0x2b3bfa0 reviewed Jan 6, 2022
View reviewed changes
@DavidGOrtega DavidGOrtega temporarily deployed to internal January 6, 2022 19:05 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal January 11, 2022 17:46 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal January 11, 2022 17:54 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal January 11, 2022 18:12 Inactive
@DavidGOrtega DavidGOrtega changed the title GL dind and volumes Runner docker volumes Jan 14, 2022
@DavidGOrtega DavidGOrtega mentioned this pull request Jan 14, 2022
Merged
@DavidGOrtega DavidGOrtega marked this pull request as ready for review January 16, 2022 10:23
@DavidGOrtega DavidGOrtega temporarily deployed to internal January 17, 2022 10:39 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal January 17, 2022 16:26 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal January 17, 2022 16:35 Inactive
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Jan 17, 2022
Closed
3 tasks
casperdcl
casperdcl reviewed Jan 19, 2022
View reviewed changes
@DavidGOrtega DavidGOrtega temporarily deployed to internal January 19, 2022 14:59 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal January 19, 2022 15:12 Inactive
0x2b3bfa0
0x2b3bfa0 reviewed Jan 21, 2022
View reviewed changes
@DavidGOrtega @0x2b3bfa0
remove docker
4def4c9 
Co-authored-by: Helio Machado <0x2b3bfa0+git@googlemail.com>
@DavidGOrtega DavidGOrtega temporarily deployed to internal January 21, 2022 09:20 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal January 21, 2022 11:02 Inactive
@casperdcl casperdcl merged commit 471484a into master Jan 21, 2022
@casperdcl casperdcl deleted the gl-docker-volumes-dind branch January 21, 2022 11:11
casperdcl added a commit to iterative/cml.dev that referenced this pull request Jan 21, 2022
@casperdcl
ref/runner: --docker-volumes
6e9c141 
- follow-up to iterative/cml#861
@casperdcl casperdcl mentioned this pull request Jan 21, 2022
Merged
@casperdcl casperdcl added the external-request You asked, we did label Jul 19, 2022
@snyk-bot snyk-bot mentioned this pull request Dec 5, 2022
Merged
@terrorizer1980 terrorizer1980 mentioned this pull request Dec 6, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jan 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 approved these changes

+1 more reviewer

@casperdcl casperdcl casperdcl approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@DavidGOrtega DavidGOrtega

Labels
ci-gitlab cml-runner Subcommand external-request You asked, we did
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runner: Docker socket mounts
3 participants
@DavidGOrtega @0x2b3bfa0 @casperdcl