Skip to content

Conversation

ripecosta
Copy link
Contributor

This PR updates dependencies to latest versions, patching some security vulnerabilities in the process.

Before After
npm audit Screenshot 2025-05-13 at 20 47 39 Screenshot 2025-05-13 at 20 47 10

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Copy link

@@ -10,6 +10,7 @@ module.exports = {
parser: '@typescript-eslint/parser',
parserOptions: {
project: './tsconfig.lint.json',
warnOnUnsupportedTypeScriptVersion: false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer needed in husky v9

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this file are linting related.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this file were made to address a warning when upgrading to vitest v3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to this file are linting related.

# @see https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#expanding-or-adding-matrix-configurations
include:
- collectCoverage: true
node: '20.x'
node: '22.x'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well run on latest

"@babel/preset-react": "^7.23.3",
"@babel/register": "^7.22.15",
"@babel/core": "^7.27.1",
"@babel/plugin-transform-async-generator-functions": "^7.27.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @babel/plugin-proposal-async-generator-functions package is deprecated with the following message:

This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-async-generator-functions instead.

@ripecosta ripecosta marked this pull request as ready for review May 13, 2025 20:00
@ripecosta
Copy link
Contributor Author

Hi @adrai. I opened this PR with a bit of maintenance work. Have a look when you have the chance and let me know if you're happy with it. Thanks!

@coveralls
Copy link

Coverage Status

coverage: 95.195% (-0.6%) from 95.785%
when pulling 1758290 on ripecosta:rc/updates
into ec86d00 on i18next:master.

@adrai
Copy link
Member

adrai commented May 13, 2025

lgtm

@adrai adrai merged commit 32979d8 into i18next:master May 13, 2025
9 of 10 checks passed
@@ -162,8 +162,7 @@
}
return matched;
};
const deepFind = function (obj, path) {
let keySeparator = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : '.';
const deepFind = (obj, path, keySeparator = '.') => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ripecosta I hope this type of stuff will not break in some user land scenarios, for the next release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same. TBH I was surprised npm run build producing this change because it seems seems to have been introduced way back in v20 (commit) and later moved to another file in v22 (commit). I'm not sure where the deepFind with two params came from.

@ripecosta ripecosta deleted the rc/updates branch May 14, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants