Bugfix MDTest calculation of multiple iterations was incorrect. #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adilger
reviewed
Nov 28, 2020
src/mdtest.c
Outdated
| for (j = 0; j < iterations; j++) { | ||
| curr = all[(k*tableSize*iterations) | ||
| + (j*tableSize) + i]; | ||
| for (j = 0; j < iterations; j++) { |
There was a problem hiding this comment.
Using better variable names than "i" and "j" and "k", like "iter" and "op" might avoid this kind of bug in the future.
Also, putting the "j*tableSize*size + k*tableSize + i" calculation into a small helper function like:
int calc_allreduce_index(int index, int iter, int op)
(or whatever) and using it in the places where all[] is accessed would also avoid similar usage bugs.
This kind of information would be very useful in the commit message of the patch itself, rather than just the PR, since it will be easily available with the code in the future. |
JulianKunkel
added a commit
that referenced
this pull request
Dec 2, 2020
JulianKunkel
added a commit
that referenced
this pull request
Dec 3, 2020
Backmerged #281 to fix iteration number
glennklockwood
added a commit
to glennklockwood/ior
that referenced
this pull request
Dec 18, 2020
glennklockwood
added a commit
that referenced
this pull request
Dec 22, 2020
…for 3.3 release branch (#299)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug reported by Rick to increase clarity. Thanks!
The previous offset calculation when using multiple iterations was:
for (i = start; i < stop; i++) // i = table position == test number
for (k=0; k < size; k++)
for (j = 0; j < iterations; j++)
value = all[(k * tableSize * iterations) + (j*tableSize) + i];
Note that the mean and min/max was then computed over these values.
But as the values were stored in memory in the order: iteration, rank, table
the correct term is: value = all[j * tableSize * size + k * tableSize + i];
Assume iterations = 2 and size = 3, the value for the test i=0 was computed from:
all[0 * 2 *tbl + 0 * tbl] = 0tbl
all[0 * 2 *tbl + 1 * tbl] = 1tbl
all[1 * 2 *tbl + 0 * tbl] = 2tbl
all[1 * 2 *tbl + 1 * tbl] = 3tbl
all[2 * 2 *tbl + 0 * tbl] = 4tbl
all[2 * 2 *tbl + 1 * tbl] = 5tbl
A more clear traversal would have been:
all[0 * 3 *tbl + 0 * tbl] = 0tbl
all[0 * 3 *tbl + 1 * tbl] = 1tbl
all[0 * 3 *tbl + 2 * tbl] = 2tbl
all[1 * 3 *tbl + 0 * tbl] = 3tbl
all[1 * 3 *tbl + 1 * tbl] = 4tbl
all[1 * 3 *tbl + 2 * tbl] = 5tbl
In that sense, it wasn't a functional bug but it decreased readability and now that we want to print the performance of the individual ranks, it is useful to fix this.