feat: allow dashes in begin and end dates #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is nice, but I'm wondering if it would be worthwhile to support many date formats, like in the ledger file parser. Like this: Line 194 in ffdee7b |
Other date formats were already allowed for entries in the ledger data file, and it was odd to hit time parse errors for dates written in these other formats with the -b/--begin-date and -e/--end-date flags.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time format was already allowed for entries in the ledger data file, and it was odd to hit time parse errors for dates written in the same format with the -b/--begin-date and -e/--end-date flags.