Skip to content

fix(js): allow pinning importmaps with gem #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2024
Merged

fix(js): allow pinning importmaps with gem #49

merged 1 commit into from
Feb 15, 2024

Conversation

mhenrixon
Copy link
Contributor

@mhenrixon mhenrixon commented Feb 12, 2024 •
edited
Loading

Since import maps JSPM and the javascript ecosystem are a mess in their current state, allow import maps to match the assets served by the gem rather than download them from JSPM.

pin "@turbo-boost/streams", to: "@turbo-boost/streams.js", preload: false
pin "@turbo-boost/commands", to: "@turbo-boost/commands.js", preload: false
pin "@turbo-boost/elements", to: "@turbo-boost/elements.js", preload: false
pin "alpinejs", preload: false # @3.13.5
pin "@alpinejs/morph", to: "@alpinejs--morph.js", preload: false # @3.13.5

That fixes that problem; I'm happy with this solution for now; seems fair since JSPM never updates. Perhaps we can update the documentation for importmaps to the following:

  1. fix(js): allow pinning importmaps with gem turbo_boost-streams#51
  2. fix(js): allow pinning importmaps with gem turbo_boost-commands#122
  3. fix(js): allow pinning importmaps with gem #49

This is verified to be working with:

gem "turbo_boost-streams",  github: "mhenrixon/turbo_boost-streams"
gem "turbo_boost-commands", github: "mhenrixon/turbo_boost-commands"
gem "turbo_boost-elements", github: "mhenrixon/turbo_boost-elements"

@mhenrixon
fix(js): allow pinning importmaps with gem
039bb3f 
Since import maps JSPM and the javascript ecosystem are a mess in their current state, allow import maps to match the assets served by the gem rather than download them from JSPM.
This was referenced Feb 12, 2024
Merged
Merged
@hopsoft hopsoft merged commit 1dfffc8 into hopsoft:main Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hopsoft hopsoft hopsoft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhenrixon @hopsoft