fix(deps): Add missing SSL library to Pluto image #7286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 Walkthrough""" WalkthroughThe changes update the Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant flake.nix
participant Docker
participant hopr-pluto
Developer->>flake.nix: Add openssl to image contents
Developer->>flake.nix: Set LD_LIBRARY_PATH for OpenSSL
Developer->>flake.nix: Expand exposed TCP ports to 3003-3018
flake.nix->>Docker: Build hopr-pluto image with new config
Docker->>hopr-pluto: Run image with OpenSSL and updated ports
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the Pluto Docker image includes the SSL library and adjusts its port exposure.
- Adds
opensslto the image dependencies - Sets
LD_LIBRARY_PATHto the OpenSSL library directory - Expands exposed port range from 3001–3006 to 3003–3018
Comments suppressed due to low confidence (2)
flake.nix:530
- [nitpick] The exposed port range has been significantly expanded; please confirm that opening all these ports is intentional and won't introduce security or maintenance concerns.
"3003-3018/tcp" = { };
flake.nix:472
- Consider adding or updating a test that verifies the Docker image includes the SSL library and that SSL-dependent functionality works as expected.
openssl
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Teebor-Choka
approved these changes
Jul 3, 2025
|
Could we add a basic pluto check that the container is running? |
|
I'll tackle this tomorrow. Thing is that it would require to build the image on each commit, and this is slow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies fix in #7153 for the Pluto docker image