-
Notifications
You must be signed in to change notification settings - Fork 97
chore(deps): Bi-weekly update 20250701 #7273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 Walkthrough## Walkthrough
This change updates the formatting style of error messages, debug prints, and assertion messages across the codebase to use Rust's inline variable interpolation syntax. It also upgrades multiple dependency versions in Rust and Python, updates the Rust toolchain to 1.88, modifies the DNS resolver instantiation, and refreshes several GitHub Actions workflow dependencies.
## Changes
| Files/Paths | Change Summary |
|-------------------------------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------|
| `.github/workflows/*.yaml` | Updated `step-security/harden-runner` action from v2.12.1 to v2.12.2 in all workflows; updated other actions in some files.|
| `.github/renovate.json` | Removed `hickory-resolver` from Renovate ignore list. |
| `Cargo.toml`, `common/network-types/Cargo.toml`, `sdk/python/api/pyproject.toml`, `pyproject.toml`| Updated dependency versions for Rust and Python packages. |
| `rust-toolchain.toml` | Updated Rust toolchain version from 1.87 to 1.88. |
| `common/network-types/src/types.rs` | Switched DNS resolver instantiation to new builder API; updated method signatures. |
| `chain/api/src/config.rs`, `chain/api/src/lib.rs`, `chain/types/src/chain_events.rs`, `chain/types/src/utils.rs` | Updated string formatting in error/debug messages to use inline variable interpolation. |
| `common/primitive-types/src/balance.rs`, `hopli/src/faucet.rs`, `hopli/src/identity.rs`, `hopli/src/key_pair.rs`, `hopli/src/methods.rs`, `hopli/src/network_registry.rs`, `hopli/src/safe_module.rs`, `hopli/src/win_prob.rs` | Changed all formatting macros to use Rust's inline variable interpolation syntax. |
| `logic/path/src/selectors/dfs.rs`, `misc/platform/src/file.rs`, `transport/protocol/tests/common/mod.rs` | Updated panic/assertion/debug message formatting to inline variable interpolation. |
| `common/network-types/src/session/state.rs`, `transport/session/src/balancer/rate_limiting.rs`, `transport/session/src/initiation.rs`, `transport/session/src/manager.rs` | Updated test code formatting for assertions and debug prints. |
| `hoprd/hoprd/src/main.rs`, `hoprd/keypair/src/key_pair.rs`, `hoprd/rest-api/src/middleware/preconditions.rs` | Modernized formatting in main, keypair, and middleware modules. |
## Sequence Diagram(s)
```mermaid
sequenceDiagram
participant Client
participant IpOrHost
participant HickoryResolver
Client->>IpOrHost: resolve_tokio()
IpOrHost->>HickoryResolver: Resolver::builder_tokio()?.build()
IpOrHost->>IpOrHost: resolve(self, resolver)
IpOrHost-->>Client: Vec<SocketAddr> or error Possibly related PRs
Suggested labels
Suggested reviewers
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR performs a bi-weekly dependency update, refactors the DNS resolver API, and enriches logging with peer IDs.
- Include
peer_id
in swarm error logs. - Switch from the old
AsyncResolver
API to the newResolver
builder innetwork-types
. - Bump several workspace dependencies (
alloy
,hickory-resolver
,libp2p
,sea-orm
, etc.) and update Renovate config.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
transport/p2p/src/swarm.rs | Added peer_id field to the structured error log. |
common/network-types/src/types.rs | Replaced AsyncResolver calls and signature with Resolver builder API. |
common/network-types/Cargo.toml | Renamed hickory-resolver runtime feature from tokio-runtime to tokio . |
Cargo.toml | Updated pinned versions of alloy , hickory-resolver , libp2p , sea-orm , and others. |
.github/renovate.json | Removed hickory-resolver from ignored dependencies for Renovate. |
Comments suppressed due to low confidence (2)
common/network-types/src/types.rs:105
- This change alters the public
resolve
signature fromAsyncResolver
toResolver
, which is a breaking API change. Please update the crate's changelog and consider bumping the major version if semver guarantees are in place.
) -> std::io::Result<Vec<SocketAddr>> {
common/network-types/src/types.rs:100
- The doc comment should mention the new
Resolver<P>
type instead ofAsyncResolver<P>
and briefly describe the builder-based configuration changes.
/// Tries to resolve the DNS name and returns all IP addresses found.
4e9d61f
to
eb9997a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last deps update was 0fb2068
So this is not yet bi-weekly, let wait for one more week.
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Tibor <9529609+Teebor-Choka@users.noreply.github.com>
chore(fix): lint chore(fix): lint
eb9997a
to
3f6ee8d
Compare
Co-authored-by: ausias-armesto <ausiasarmesto@gmail.com> Co-authored-by: Tibor <9529609+Teebor-Choka@users.noreply.github.com> Co-authored-by: Tino Breddin <tino@hoprnet.org> Co-authored-by: Tino Breddin <tolbrino@users.noreply.github.com> Co-authored-by: Jean Demeusy <61140535+jeandemeusy@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Tibor <9529609+Teebor-Choka@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lukas <lukas.pohanka@inina.net>
This pull request primarily focuses on updating dependencies across multiple workflow files to ensure the latest versions are used and removing an unused dependency from the
renovate.json
file. The updates enhance security and maintain compatibility with newer features.Dependency updates:
.github/workflows/*
: Updatedstep-security/harden-runner
to versionv2.12.2
across all workflow files for improved security and compatibility. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22].github/workflows/bencher.yaml
: Updatedbencherdev/bencher
to versionv0.5.2
for benchmarking improvements..github/workflows/build-dappnode.yaml
: Updateddocker/setup-buildx-action
to versionv3.11.1
for Docker build enhancements.Dependency removal:
.github/renovate.json
: Removedhickory-resolver
from the list of dependencies, indicating it is no longer required.