Skip to content

fix(deps): Add python313 to Pluto #7243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

fix(deps): Add python313 to Pluto #7243

merged 1 commit into from
Jun 16, 2025

Conversation

jeandemeusy
Copy link
Contributor

This PR fixes pluto.

It wasn't working anymore probably because of structural changes in the nix shells and their dependancies.

@Copilot Copilot AI review requested due to automatic review settings June 13, 2025 10:30
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 13, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

The change updates the hopr-pluto Docker image configuration in flake.nix by adding the python313 package to its list of included contents. No other files or logic are modified.

Changes

File(s) Change Summary
flake.nix Added python313 to the contents of the hopr-pluto image

Possibly related PRs

Suggested labels

toolchain

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6339a9e and 1a5a99b.

📒 Files selected for processing (1)
  • flake.nix (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Docs / Rust docs
🔇 Additional comments (1)
flake.nix (1)

474-474:

✅ Verification successful

Verify availability of python313 in pinned nixpkgs
The release-24.11 channel may not yet expose a top-level python313 attribute. Ensure it exists or update the pinned nixpkgs to a version that includes Python 3.13.

🌐 Web query:

Does the Nixpkgs release-24.11 include the `python313` package attribute?

💡 Result:

The Nixpkgs release 24.11 does include the python313 package attribute.

Evidence supporting this includes:

  • A user report mentions explicitly installing Nixpkgs stable channel 24.11 with python313 and encountering updates involving Python versions 3.13 and 3.14 alpha, which shows python313 is recognized in 24.11[2].

  • The package search results for the unstable channel show a python313 package attribute representing Python 3.13.3, indicating that Python 3.13 is available in recent Nixpkgs versions, which are closely related to and eventually propagate to stable releases like 24.11[1].

  • Nixpkgs typically maintains and backports newer supported Python versions to stable releases, reflected by the presence of attributes like python310Packages, python311Packages, and so on, and python313 fits this progression[9].

There is no indication in the release notes or issues that python313 was excluded from 24.11; on the contrary, it appears to be part of the stable offerings in that release cycle.

Summary: Yes, Nixpkgs release 24.11 includes the python313 package attribute, allowing users to use Python 3.13 in that stable channel. This is confirmed by user reports of the package's usage in 24.11 and package search evidence[1][2][9].

Citations:

python313 is supported in Nixpkgs release-24.11
Verified that the stable 24.11 channel exposes the python313 attribute, so the current flake pin already provides Python 3.13—no update required.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the toolchain Developer and product happiness label Jun 13, 2025
@jeandemeusy jeandemeusy requested a review from a team June 13, 2025 10:30
Copilot
Copilot AI reviewed Jun 13, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the flake.nix configuration to include Python 3.13 in Pluto’s runtime dependencies, addressing breakages caused by recent Nix shell structure changes.

  • Add python313 to Pluto’s dependency list
Comments suppressed due to low confidence (2)

flake.nix:474

  • [nitpick] Consider adding or updating integration tests to verify that Pluto functions correctly with Python 3.13 now that this dependency is included.
python313

flake.nix:474

  • Ensure that python313 is properly imported or bound in this flake before use; otherwise, evaluation will fail with an undefined variable error.
python313

@Teebor-Choka Teebor-Choka changed the title Add python313 to the Pluto deps fix(deps): Add python313 to Pluto Jun 13, 2025
@ausias-armesto ausias-armesto marked this pull request as draft June 13, 2025 15:40
@ausias-armesto ausias-armesto marked this pull request as ready for review June 13, 2025 15:40
@jeandemeusy jeandemeusy merged commit dbbf429 into master Jun 16, 2025
58 of 61 checks passed
@jeandemeusy jeandemeusy deleted the jean/fix-pluto branch June 16, 2025 08:09
@coderabbitai coderabbitai bot mentioned this pull request Jul 3, 2025
Merged
@jeandemeusy jeandemeusy linked an issue Jul 10, 2025 that may be closed by this pull request
Pluto doesn't work #7232
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@NumberFour8 NumberFour8 NumberFour8 approved these changes

Assignees

@jeandemeusy jeandemeusy

Labels
toolchain Developer and product happiness
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pluto doesn't work
2 participants
@jeandemeusy @NumberFour8