Skip to content

Fix deploy config file #7212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2025
Merged

Fix deploy config file #7212

merged 2 commits into from
Jun 2, 2025

Conversation

jeandemeusy
Copy link
Contributor

No description provided.

@Copilot Copilot AI review requested due to automatic review settings June 2, 2025 13:25
@jeandemeusy jeandemeusy self-assigned this Jun 2, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 2, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

The configuration file for the AutoRedeeming strategy was updated to change the minimum_redeem_ticket_value from "2000000000000000000 HOPR" to "2 wxHOPR". No other configuration keys or values were altered.

Changes

File(s) Change Summary
deploy/compose/hoprd/conf/hoprd.cfg.yaml Updated minimum_redeem_ticket_value from "2000000000000000000 HOPR" to "2 wxHOPR" in the AutoRedeeming strategy configuration.

Possibly related PRs

Suggested labels

crate:hoprd

Suggested reviewers

  • tolbrino
📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8a7df74 and 4c799dd.

📒 Files selected for processing (1)
  • deploy/compose/hoprd/conf/hoprd.cfg.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: tests-smoke (redeeming)
  • GitHub Check: tests-smoke (session)
  • GitHub Check: tests-smoke (integration)
  • GitHub Check: tests-smoke (win_prob)
  • GitHub Check: tests-smoke (rest_api)
  • GitHub Check: tests-smoke (websocket_api)
  • GitHub Check: tests-smoke (hopli)
  • GitHub Check: tests-unit

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jeandemeusy jeandemeusy requested a review from esterlus June 2, 2025 13:25
@jeandemeusy jeandemeusy linked an issue Jun 2, 2025 that may be closed by this pull request
Fix prefered deployment sample files #7211
Closed
@jeandemeusy jeandemeusy requested a review from Teebor-Choka June 2, 2025 13:25
Copilot
Copilot AI reviewed Jun 2, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the minimum redeem ticket value in the HOPR deployment config to use a more human-readable unit.

  • Switched from raw base-unit amount in HOPR to wxHOPR unit
  • Adjusted the configured threshold value accordingly
Comments suppressed due to low confidence (1)

deploy/compose/hoprd/conf/hoprd.cfg.yaml:18

  • Verify that the configuration parser accepts the "wxHOPR" suffix; if not, either update the parser to recognize this unit or revert to a supported unit format to prevent runtime errors.
minimum_redeem_ticket_value: "2 wxHOPR"

esterlus
esterlus approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member

@esterlus esterlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

tolbrino
tolbrino approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@tolbrino tolbrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

@tolbrino tolbrino added this to the 3.0.0 milestone Jun 2, 2025
@jeandemeusy jeandemeusy merged commit 7e5cb68 into master Jun 2, 2025
33 checks passed
@jeandemeusy jeandemeusy deleted the config/update-deploy-config branch June 2, 2025 13:40
This was referenced Jul 18, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@tolbrino tolbrino tolbrino approved these changes

@esterlus esterlus esterlus approved these changes

@Teebor-Choka Teebor-Choka Awaiting requested review from Teebor-Choka Teebor-Choka is a code owner

Assignees

@jeandemeusy jeandemeusy

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Fix prefered deployment sample files
3 participants
@jeandemeusy @tolbrino @esterlus