Skip to content

Lower the TX transmission timeout #7204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 30, 2025
Merged

Lower the TX transmission timeout #7204

merged 6 commits into from
May 30, 2025

Conversation

NumberFour8
Copy link
Contributor

Lowers the timeout for transmitting a transaction on-chain from 30s to 5s

Adds some more informative logs

@NumberFour8
Lower the TX transmission timeout
141c312 
Lowers the timeout for transmitting a transaction on-chain from 30s to 5s

Adds some more informative logs
@NumberFour8 NumberFour8 requested a review from a team May 30, 2025 14:55
@NumberFour8 NumberFour8 self-assigned this May 30, 2025
@NumberFour8 NumberFour8 marked this pull request as ready for review May 30, 2025 14:55
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 30, 2025 •
edited
Loading

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

This update adjusts a comment in action_queue.rs, changes the default transaction submission wait timeout in executors.rs from 30 to 5 seconds, and enhances error handling and warning logging for duplicate log entries in logs.rs. The hopr-chain-api package version was bumped from 0.5.0 to 0.5.1. No public interfaces or control flows are modified.

Changes

File(s) Change Summary
chain/actions/src/action_queue.rs Minor comment correction for clarity; no logic changes.
chain/api/src/executors.rs Changed default max_tx_submission_wait in RpcEthereumClientConfig from 30s to 5s; updated doc comment.
chain/api/Cargo.toml Bumped hopr-chain-api version from 0.5.0 to 0.5.1.
db/sql/src/logs.rs Improved error handling and added warning logs for duplicate log/log_status insertions.

Possibly related PRs

  • Improve some Logs DB queries #6649: Refactors query logic and adds logging in db/sql/src/logs.rs, focusing on checksum updates and log counting, which relates to error handling and logging in the same file.

Suggested labels

crate:chain-indexer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label May 30, 2025
Teebor-Choka
Teebor-Choka reviewed May 30, 2025
View reviewed changes
@Teebor-Choka Teebor-Choka added this to the 3.0.0 milestone May 30, 2025
@Teebor-Choka Teebor-Choka merged commit 9b6fc52 into master May 30, 2025
76 of 85 checks passed
@Teebor-Choka Teebor-Choka deleted the lukas/lower-tx-transmission-timeout branch May 30, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Teebor-Choka Teebor-Choka Teebor-Choka approved these changes

Assignees

@NumberFour8 NumberFour8

Labels
crate:hopr-chain-actions crate:hopr-chain-api crate:hopr-db-sql dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@NumberFour8 @Teebor-Choka