ci: Fix log upload #7160
ci: Fix log upload #7160
Conversation
📝 Walkthrough""" WalkthroughThe workflows were updated to simplify test execution commands and consolidate log compression and upload steps in the test jobs. The cleanup workflow added an explicit repository checkout step with credential persistence disabled. The update-flake-lock workflow modified cron trigger quoting and elevated repository content permissions from read to write. Additionally, protocol configuration JSON was updated by removing the "monte_rosa" network and expanding version ranges for "dufour" and "rotsee" networks. Changes
Sequence Diagram(s)sequenceDiagram
participant Workflow
participant TestJob
participant LogHandler
participant GCloudStorage
Workflow->>TestJob: Run unit tests (single-line command)
Workflow->>TestJob: Run smoke tests
TestJob->>LogHandler: Copy logs to unique /tmp directory and compress
LogHandler->>GCloudStorage: Upload compressed logs using gcloud storage cp
Possibly related PRs
Suggested labels
Suggested reviewers
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Pull Request Overview
This pull request aims to fix the log upload process in the CI workflow.
- Simplifies the unit test execution command by converting a multi-line command block into a single-line command.
- Introduces a new step to dynamically compute the temporary folder path and updates the upload step to utilize this computed path in two different jobs.
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
.github/workflows/tests.yaml (1)
234-248:⚠️ Potential issueInconsistent consumption of dynamic tmp path in
tests-smoke-hopliThe
find-tmp-pathstep (lines 234–239) computes a relativetmp-path, but the very next "Upload test logs" step (lines 240–248) still references the hardcoded/tmp/. As a result, the dynamic path is never used. Please update it to:- path: /tmp/ + path: ${{ steps.find-tmp-path.outputs.tmp-path }}
🧹 Nitpick comments (1)
.github/workflows/tests.yaml (1)
234-239: Consider refactoring duplicatedfind-tmp-pathlogicThe same
find-tmp-pathstep is added in both smoke test jobs. To reduce duplication and simplify future updates, you might extract this into a reusable GitHub Actions composite step or call a common workflow.Also applies to: 345-350
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/tests.yaml(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: tests-smoke-hopli
- GitHub Check: tests-unit
🔇 Additional comments (3)
.github/workflows/tests.yaml (3)
57-59: Validate simplified unit test invocationEnsure that
nix build -L .#hopr-teststill executes the unit tests and fails the job on test errors as expected, since the previous multi-line shell block may have handled exit codes or log collection differently.
345-350: Dynamic relative path for temp directory intests-smokeis correctThe new
find-tmp-pathstep accurately computes a relative path to/tmpand sets it astmp-path, improving portability and avoiding hardcoded paths.
351-356: Upload test logs via computedtmp-pathintests-smokeSwitching the
pathin the "Upload test logs" step to usesteps.find-tmp-path.outputs.tmp-pathensures the correct directory is uploaded. Looks good!
Uh oh!
There was an error while loading. Please reload this page.