Skip to content

deps: Remove surf and surf-governor #7157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2025
Merged

deps: Remove surf and surf-governor #7157

merged 2 commits into from
May 19, 2025

Conversation

Teebor-Choka
Copy link
Contributor

@Teebor-Choka Teebor-Choka commented May 19, 2025 •
edited
Loading

This pull request removes references to the surf library and its related components from the project. The changes involve cleaning up dependencies and adjusting logging configurations accordingly.

Dependency cleanup:

  • Cargo.toml: Removed the surf and surf-governor dependencies from the project. These libraries are no longer used.

Logging configuration update:

  • hoprd/hoprd/src/main.rs: Removed the logging directive for surf::middleware::logger::native in the init_logger function, as the surf library has been removed.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 19, 2025 •
edited
Loading

📝 Walkthrough

"""

Walkthrough

The changes remove the surf and surf-governor dependencies from the project's Cargo.toml and eliminate a logging directive related to surf in the logger initialization within the main application code. No changes were made to exported or public entities.

Changes

File(s) Change Summary
Cargo.toml Removed surf and surf-governor dependencies from the workspace.
hoprd/hoprd/src/main.rs Removed the logging directive for surf::middleware::logger::native from the logger initialization.

Possibly related issues

Suggested reviewers

  • tolbrino
    """

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5fa2990 and da2956c.

📒 Files selected for processing (1)
  • Cargo.toml (0 hunks)
💤 Files with no reviewable changes (1)
  • Cargo.toml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Teebor-Choka Teebor-Choka self-assigned this May 19, 2025
@github-actions github-actions bot added dependencies Pull requests that update a dependency file crate:hoprd labels May 19, 2025
@Teebor-Choka Teebor-Choka marked this pull request as ready for review May 19, 2025 10:34
@Teebor-Choka Teebor-Choka requested review from Copilot and a team May 19, 2025 10:34
@Teebor-Choka Teebor-Choka added this to the 3.0.0 milestone May 19, 2025
@Teebor-Choka Teebor-Choka linked an issue May 19, 2025 that may be closed by this pull request
Remove the unmaintained surf dependency #7156
Closed
Copilot
Copilot AI reviewed May 19, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the unused surf and surf-governor dependencies and cleans up the corresponding logging configuration.

  • Removed surf and surf-governor entries from Cargo.toml.
  • Deleted the surf::middleware::logger::native logging directive in init_logger.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
hoprd/hoprd/src/main.rs Removed obsolete surf logging directive
Cargo.toml Deleted unused surf and surf-governor deps

@Teebor-Choka Teebor-Choka enabled auto-merge May 19, 2025 10:40
@Teebor-Choka Teebor-Choka added this pull request to the merge queue May 19, 2025
Merged via the queue into master with commit a48898f May 19, 2025
28 of 31 checks passed
@Teebor-Choka Teebor-Choka deleted the kauki/deps/remove-surf-dependency branch May 19, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@tolbrino tolbrino tolbrino approved these changes

Assignees

@Teebor-Choka Teebor-Choka

Labels
crate:hoprd dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Remove the unmaintained surf dependency
2 participants
@Teebor-Choka @tolbrino