Skip to content

toolchain: Update Rust to 1.87 #7154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2025
Merged

toolchain: Update Rust to 1.87 #7154

merged 2 commits into from
May 19, 2025

Conversation

Teebor-Choka
Copy link
Contributor

@Teebor-Choka Teebor-Choka commented May 19, 2025 •
edited
Loading

This pull request includes two minor updates to the Rust project configuration files. The changes involve formatting improvements and updating the Rust toolchain version.

Configuration updates:

  • Cargo.toml: Reformatted the criterion dependency to place all features on a single line for consistency.
  • rust-toolchain.toml: Updated the Rust toolchain version from 1.86 to 1.87.

Fix linting and formatting issues in master.

@Teebor-Choka Teebor-Choka added this to the 3.0.0 milestone May 19, 2025
@Teebor-Choka Teebor-Choka requested a review from a team May 19, 2025 08:59
@Teebor-Choka Teebor-Choka self-assigned this May 19, 2025
@Teebor-Choka Teebor-Choka marked this pull request as ready for review May 19, 2025 08:59
@Copilot Copilot AI review requested due to automatic review settings May 19, 2025 08:59
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 19, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

The Rust toolchain version in the rust-toolchain.toml file was updated from 1.86 to 1.87. Additionally, the criterion dependency declaration in Cargo.toml was reformatted from a multiline to a single-line feature list. A trailing blank line after a comment in logic/path/src/channel_graph.rs was removed. No other changes were made to public or exported entities.

Changes

File(s) Change Summary
rust-toolchain.toml Updated Rust toolchain version from 1.86 to 1.87.
Cargo.toml Reformatted criterion dependency features from multiline to single-line array syntax.
logic/path/src/channel_graph.rs Removed a trailing blank line immediately following a comment; no functional code changes made.

Possibly related PRs

Suggested labels

dependencies

Suggested reviewers

  • tolbrino
  • NumberFour8

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa448f8 and 798740b.

📒 Files selected for processing (1)
  • logic/path/src/channel_graph.rs (0 hunks)
💤 Files with no reviewable changes (1)
  • logic/path/src/channel_graph.rs
⏰ Context from checks skipped due to timeout of 90000ms (9)
  • GitHub Check: hoprd / docker
  • GitHub Check: hopli / docker
  • GitHub Check: tests-smoke-hopli
  • GitHub Check: Docs / Rust docs
  • GitHub Check: tests-unit-nightly
  • GitHub Check: tests-unit
  • GitHub Check: zizmor
  • GitHub Check: Linter
  • GitHub Check: Cargo Audit
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copilot
Copilot AI reviewed May 19, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Bump the Rust toolchain version to leverage updates in Rust 1.87.

  • Updated the channel in rust-toolchain.toml from 1.86 to 1.87.

@github-actions github-actions bot added toolchain Developer and product happiness dependencies Pull requests that update a dependency file labels May 19, 2025
@Teebor-Choka Teebor-Choka changed the title Update Rust to 1.87 toolchain: Update Rust to 1.87 & update nix flake May 19, 2025
@Teebor-Choka Teebor-Choka force-pushed the kauki/toolchain/update-rust branch from 4a3792f to fa448f8 Compare May 19, 2025 10:13
@Teebor-Choka Teebor-Choka changed the title toolchain: Update Rust to 1.87 & update nix flake toolchain: Update Rust to 1.87 May 19, 2025
@Teebor-Choka Teebor-Choka merged commit 489b354 into master May 19, 2025
29 of 31 checks passed
@Teebor-Choka Teebor-Choka deleted the kauki/toolchain/update-rust branch May 19, 2025 10:39
@coderabbitai coderabbitai bot mentioned this pull request Jun 30, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Aug 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@tolbrino tolbrino tolbrino approved these changes

@NumberFour8 NumberFour8 NumberFour8 approved these changes

Assignees

@Teebor-Choka Teebor-Choka

Labels
crate:hopr-path dependencies Pull requests that update a dependency file toolchain Developer and product happiness
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Teebor-Choka @tolbrino @NumberFour8