-
Notifications
You must be signed in to change notification settings - Fork 97
docker: Fix missing SSL library in the image #7153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe code in Changes
Sequence Diagram(s)sequenceDiagram
participant DockerBuilder
participant pkgs
participant buildLayeredImage
DockerBuilder->>pkgs: makeLibraryPath(pkgs.openssl)
pkgs-->>DockerBuilder: libPath
DockerBuilder->>buildLayeredImage: Pass config with LD_LIBRARY_PATH including libPath
buildLayeredImage-->>DockerBuilder: Build Docker image with updated environment
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- nix/docker-builder.nix: Language not supported
This pull request refactors the
nix/docker-builder.nix
file to improve readability and functionality by reorganizing code and adding a new library path. The most important changes include consolidating the parameter declaration, adding a library path for OpenSSL, and simplifying thecontents
array formatting.Refactoring and functionality improvements:
libPath
variable to include the OpenSSL library path, and updated theEnv
array to set theLD_LIBRARY_PATH
environment variable. This ensures that the necessary libraries are available at runtime.contents
array by combining elements into a single line, making the code more concise.