Add caching and query DB less frequently #6132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teebor-Choka
approved these changes
Mar 22, 2024
| @@ -18,24 +18,41 @@ pub trait HoprDbResolverOperations { | |||
| #[async_trait] | |||
| impl HoprDbResolverOperations for HoprDb { | |||
| async fn resolve_packet_key(&self, onchain_key: &Address) -> Result<Option<OffchainPublicKey>> { | |||
There was a problem hiding this comment.
Theoretically this API could disappear and the OffchainKeyOrAddress could take a Arc reference and resolve dynamically into either Address or OffchainKey, this creating a sort of "UniversalAddress".
| @@ -1397,6 +1392,7 @@ impl HoprDbTicketOperations for HoprDb { | |||
| )) | |||
| })?; | |||
|
|
|||
| // TODO: cache this DB call too, or use the channel graph | |||
There was a problem hiding this comment.
The question is whether the SQLite cache is not sufficient, not only here, but in multiple tables and values that rarely change.
Teebor-Choka
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
get_indexer_dataandget_safe_infoDB calls are now using cache. The Indexer data especially is query very frequently across the entire code base, and changes very sporadically. Therefore, proper caching has been introduced along with the invalidation when the underlying data changes in the DB.resolve_chain_keyandresolve_packet_keyalso use cache, so packet processing pipeline can benefit from it. These calls are very often called directly from the packet processing pipeline.All caches that are used by the DB and
TicketManagerhave been moved into a separate object. This object is then referenced viaArcin the DB andTicketManagerto allow fast cloning.set_last_indexed_blockwas separated into a standalone method, to avoid invalidating Indexer Data cache too often.Integration tests were enhanced
Several unused features and dependencies were removed
Closes #6045