Changing folder for docker compose #6971

ausias-armesto · 2025-04-02T09:58:14Z

Modifies the folders for docker compose deployment to be aligned with dappNode package

coderabbitai · 2025-04-02T09:58:21Z

📝 Walkthrough

Walkthrough

This pull request restructures configuration file paths for the hoprd service. The changes update the README documentation, Docker Compose file, and the hoprd configuration file to reflect a new directory layout for configuration and data files. Adjustments include updated environment variables, volume mounts, and internal path references. No functional changes or modifications to publicly exported entities were made.

Changes

File(s)	Change Summary
`deploy/compose/README.md`	Updated file paths for hoprd configuration files. Paths now use `./hoprd/conf/` instead of the old `./hoprd_data/` layout.
`deploy/compose/docker-compose.yml`, `deploy/compose/hoprd/conf/hoprd.cfg.yaml`	• Removed `hoprd_data` volume and updated the `HOPRD_CONFIGURATION_FILE_PATH` (from `/app/hoprd.cfg.yaml` to `/app/hoprd/conf/hoprd.cfg.yaml`). • Updated volume mounts: changed data mount from `./hoprd_data:/app` to `./hoprd/data:/app/hoprd/data` and added a new mount `./hoprd/conf:/app/hoprd/conf`. • In `hoprd.cfg.yaml`, updated `db.data` from `/app/hoprd/` to `/app/hoprd/data` and `identity.file` from `"/app/hopr.id"` to `"/app/hoprd/conf/hopr.id"`.

Possibly related PRs

Update the docker compose based deployment #6307: Addresses similar restructuring of configuration file paths in docker-compose.yml.
Consolidate docker compose volume mount to allow hopr.id file creation if absent #6395: Involves modifications to volume mappings and configuration paths for the hoprd service.
Fixing the docker compose deployment setup #6347: Reflects adjustments in both docker-compose.yml and hoprd.cfg.yaml that align with the updates in this PR.

Suggested labels

crate:hoprd

Suggested reviewers

Teebor-Choka
NumberFour8
tolbrino

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

tolbrino · 2025-04-03T05:52:13Z

@ausias-armesto note that this change does not fix #6794

Teebor-Choka · 2025-04-07T11:32:18Z

@ausias-armesto pls resolve the conflicts.

coderabbitai

Actionable comments posted: 0

🔭 Outside diff range comments (1)

deploy/compose/README.md (1)

71-78: ⚠️ Potential issue

Update Configuration File Path References

The "Configure the Configuration File" section still instructs users to navigate to the hoprd_data folder to edit the hoprd.cfg.yaml file. Since the new folder structure uses ./hoprd/conf/hoprd.cfg.yaml (and correspondingly ./hoprd/conf/hopr.id), please update these instructions to maintain consistency with the new deployment layout.

🧰 Tools

🪛 LanguageTool

[uncategorized] ~73-~73: Loose punctuation mark.
Context: ... the following fields: - host.address: Set the public IP address of the machin...

(UNLIKELY_OPENING_PUNCTUATION)

[uncategorized] ~74-~74: Loose punctuation mark.
Context: ...where the node is running. - host.port: Use the P2P port which you configured i...

(UNLIKELY_OPENING_PUNCTUATION)

[uncategorized] ~75-~75: Loose punctuation mark.
Context: ...nvironment-variables). - chain.network: Change dufour to rotsee. - `chain.p...

(UNLIKELY_OPENING_PUNCTUATION)

[uncategorized] ~76-~76: Loose punctuation mark.
Context: ...dufour to rotsee. - chain.provider: Enter the RPC endpoint URL. If using a ...

(UNLIKELY_OPENING_PUNCTUATION)

[uncategorized] ~77-~77: Loose punctuation mark.
Context: ... localhost. - safe_module.safe_address: Enter the safe address created in a [1s...

(UNLIKELY_OPENING_PUNCTUATION)

[uncategorized] ~78-~78: Loose punctuation mark.
Context: ...network). - safe_module.module_address: Enter the module address created in a [...

(UNLIKELY_OPENING_PUNCTUATION)

🪛 markdownlint-cli2 (0.17.2)

77-77: Link fragments should be valid
null

(MD051, link-fragments)

78-78: Link fragments should be valid
null

(MD051, link-fragments)

🧹 Nitpick comments (1)

deploy/compose/README.md (1)

101-102: Confirm Updated Configuration File Paths in Profiles

The profiles section now correctly reflects the updated configuration file locations:

It requires the ./hoprd/conf/hoprd.cfg.yaml to be edited.

It takes the ./hoprd/conf/hopr.id file (or generates a new id encrypted with HOPRD_PASSWORD from ./env-secrets).

Please ensure these changes are consistently applied across the documentation. Additionally, consider rephrasing the sentence around HOPRD_PASSWORD for clarity in response to the language tool’s recommendation regarding colon usage before a preposition.

🧰 Tools

🪛 LanguageTool

[typographical] ~102-~102: Do not use a colon (:) before a series that is introduced by a preposition (‘from’). Remove the colon or add a noun or a noun phrase after the preposition.
Context: ... new id encrypted with HOPRD_PASSWORD from ./env-secrets - admin-ui: runs a hopr-admin frontend - `metrics...

(RP_COLON)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5304298 and 98b8466.

📒 Files selected for processing (3)

deploy/compose/README.md (1 hunks)
deploy/compose/docker-compose.yml (1 hunks)
deploy/compose/hoprd/conf/hoprd.cfg.yaml (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

deploy/compose/hoprd/conf/hoprd.cfg.yaml
deploy/compose/docker-compose.yml

🧰 Additional context used

🪛 LanguageTool

deploy/compose/README.md

[typographical] ~102-~102: Do not use a colon (:) before a series that is introduced by a preposition (‘from’). Remove the colon or add a noun or a noun phrase after the preposition.
Context: ... new id encrypted with HOPRD_PASSWORD from ./env-secrets - admin-ui: runs a hopr-admin frontend - `metrics...

(RP_COLON)

Changing dappnode packages

5304298

ausias-armesto self-assigned this Apr 2, 2025

ausias-armesto added this to the 3.0.0 milestone Apr 2, 2025

ausias-armesto mentioned this pull request Apr 2, 2025

Make internal db path unified #6537

Closed

This was linked to issues Apr 2, 2025

DAppnode package should have a separate volume for identity and database #6794

Closed

Make internal db path unified #6537

Closed

tolbrino approved these changes Apr 3, 2025

View reviewed changes

Teebor-Choka approved these changes Apr 4, 2025

View reviewed changes

Teebor-Choka approved these changes Apr 7, 2025

View reviewed changes

ausias-armesto added 3 commits April 7, 2025 23:13

Merge branch 'master' into ausias/dappnode-folders

2fa62a8

Solve merge conflict

75fac4c

Rrevert commit

98b8466

ausias-armesto enabled auto-merge April 7, 2025 22:17

coderabbitai bot reviewed Apr 7, 2025

View reviewed changes

ausias-armesto added this pull request to the merge queue Apr 7, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 7, 2025

ausias-armesto added this pull request to the merge queue Apr 8, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 8, 2025

ausias-armesto merged commit b2bb181 into master Apr 8, 2025
29 of 30 checks passed

ausias-armesto deleted the ausias/dappnode-folders branch April 8, 2025 10:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Changing folder for docker compose #6971

Changing folder for docker compose #6971

Uh oh!

ausias-armesto commented Apr 2, 2025

Uh oh!

coderabbitai bot commented Apr 2, 2025 •

edited

Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

tolbrino commented Apr 3, 2025

Uh oh!

Teebor-Choka commented Apr 7, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Changing folder for docker compose #6971

Changing folder for docker compose #6971

Uh oh!

Conversation

ausias-armesto commented Apr 2, 2025

Uh oh!

coderabbitai bot commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

tolbrino commented Apr 3, 2025

Uh oh!

Teebor-Choka commented Apr 7, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot commented Apr 2, 2025 •

edited

Loading