transport/p2p/src/lib.rs (1)

Add load tests for concurrent streams configuration

The configuration is documented in README.md, but testing coverage could be improved:

• Add load tests to verify behavior with high concurrent stream counts
• Include test cases for environment variable configuration
• Add tests to verify resource usage under maximum stream limits

🔗 Analysis chain

Line range hint 136-149: Add testing and documentation for increased concurrent streams.

To ensure reliability and maintainability:

1. Add load tests to verify behavior with increased concurrent streams.
2. Update documentation to:
   • Explain the rationale for 10240 concurrent streams
   • Document memory/resource requirements
   • Provide monitoring recommendations

Let's check for existing tests and documentation:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Look for related tests
rg -l "test.*concurrent.*stream" --type rust

# Check documentation
fd -e md -e rst . | xargs rg -l "concurrent.*stream"

Length of output: 816

---

Script:

#!/bin/bash
# Check content of the found test file
echo "=== Mixer Test Content ==="
cat transport/protocol/src/msg/mixer.rs

# Look for integration tests
echo -e "\n=== Integration Tests ==="
fd -t f -e rs test integration

# Check for configuration documentation
echo -e "\n=== Configuration Documentation ==="
fd README.md | xargs rg -l "HOPR_INTERNAL_LIBP2P"
fd -e md -e toml . | xargs rg -l "concurrent.*streams"

Length of output: 4527

---

Script:

#!/bin/bash
# Look for integration tests correctly
echo "=== Integration Tests ==="
fd -e rs -t f . | rg "integration.*test"

# Look for configuration documentation
echo -e "\n=== Configuration Files and Docs ==="
# Check for environment variable documentation
rg -A 5 "HOPR_INTERNAL_LIBP2P" --type rust --type md --type toml

# Check for any config-related files
fd -e toml -e yaml -e env . | grep -i "config\|env"

Length of output: 5581

transport/p2p/src/lib.rs (1)

149-149: Refactor duplicated configuration.

The same environment variable and default value (10240) are used for both msg and ack behaviors. Consider:

1. Extracting the shared configuration into a constant or config struct.
2. Using separate env vars if msg and ack behaviors might need different limits in the future.

Here's a suggested refactor:

+ /// Default maximum concurrent streams for libp2p request-response
+ const DEFAULT_MAX_CONCURRENT_STREAMS: usize = 10240;
+ 
+ /// Environment variable for message protocol concurrent streams
+ const ENV_MSG_MAX_STREAMS: &str = "HOPR_INTERNAL_LIBP2P_MSG_MAX_STREAMS";
+ 
+ /// Environment variable for acknowledgment protocol concurrent streams
+ const ENV_ACK_MAX_STREAMS: &str = "HOPR_INTERNAL_LIBP2P_ACK_MAX_STREAMS";

  msg: libp2p::request_response::cbor::Behaviour::<Box<[u8]>, ()>::new(
      // ...
      .with_max_concurrent_streams(
-         std::env::var("HOPR_INTERNAL_LIBP2P_MSG_ACK_MAX_TOTAL_STREAMS")
+         std::env::var(ENV_MSG_MAX_STREAMS)
              .and_then(|v| v.parse::<usize>().map_err(|_e| std::env::VarError::NotPresent))
-             .unwrap_or(1024 * 10),
+             .unwrap_or(DEFAULT_MAX_CONCURRENT_STREAMS),
      ),

  ack: libp2p::request_response::cbor::Behaviour::<Acknowledgement, ()>::new(
      // ...
      .with_max_concurrent_streams(
-         std::env::var("HOPR_INTERNAL_LIBP2P_MSG_ACK_MAX_TOTAL_STREAMS")
+         std::env::var(ENV_ACK_MAX_STREAMS)
              .and_then(|v| v.parse::<usize>().map_err(|_e| std::env::VarError::NotPresent))
-             .unwrap_or(1024 * 10),
+             .unwrap_or(DEFAULT_MAX_CONCURRENT_STREAMS),
      ),

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro