chain/indexer/src/block.rs (3)

167-172: Consider moving FastSyncMode enum to the module level for better code organization.

The FastSyncMode enum is currently defined within the start method. If you plan to use FastSyncMode elsewhere or want to improve code clarity, consider moving it to the module level.

---

506-520: Update function documentation to match parameter changes in calculate_sync_process.

The documentation for calculate_sync_process refers to parameters that may not align with the updated function signature. Please update the doc comments to reflect the current parameters current_block and start_block for clarity.

---

208-212: Refactor duplicate metric updates for METRIC_INDEXER_SYNC_SOURCE.

The code for updating METRIC_INDEXER_SYNC_SOURCE is duplicated in both the fast-sync and RPC sync sections. Consider extracting this logic into a helper function to reduce duplication and enhance maintainability.

Apply this diff to refactor the code:

-                {
-                    METRIC_INDEXER_SYNC_SOURCE.set(&["fast-sync"], 1.0);
-                    METRIC_INDEXER_SYNC_SOURCE.set(&["rpc"], 0.0);
-                }
+                Self::update_sync_source_metrics("fast-sync");

And define the helper function outside the methods:

fn update_sync_source_metrics(source: &str) {
    #[cfg(all(feature = "prometheus", not(test)))]
    {
        METRIC_INDEXER_SYNC_SOURCE.set(&["fast-sync"], if source == "fast-sync" { 1.0 } else { 0.0 });
        METRIC_INDEXER_SYNC_SOURCE.set(&["rpc"], if source == "rpc" { 1.0 } else { 0.0 });
    }
}

Also applies to: 258-262

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

chain/indexer/src/block.rs (2)

202-231: Enhance error handling in fast sync logic.

While the implementation is thorough, consider improving error handling:

1. Add error handling for database operations that could fail
2. Ensure metrics are updated even if operations fail
3. Consider using a cleanup pattern to reset metrics on failure

 if FastSyncMode::None != will_perform_fast_sync {
+    let _metrics_guard = scopeguard::guard((), |_| {
+        #[cfg(all(feature = "prometheus", not(test)))]
+        {
+            METRIC_INDEXER_SYNC_SOURCE.set(&["fast-sync"], 0.0);
+            METRIC_INDEXER_SYNC_SOURCE.set(&["rpc"], 0.0);
+        }
+    });
+
     #[cfg(all(feature = "prometheus", not(test)))]
     {
         METRIC_INDEXER_SYNC_SOURCE.set(&["fast-sync"], 1.0);
         METRIC_INDEXER_SYNC_SOURCE.set(&["rpc"], 0.0);
     }

---

530-546: Guard against potential overflow in progress calculation.

The block difference calculation and progress computation could overflow for very large block numbers. Consider using checked arithmetic operations.

-            let mut block_difference = head.saturating_sub(start_block);
+            let mut block_difference = match head.checked_sub(start_block) {
+                Some(diff) => diff,
+                None => {
+                    error!("Invalid block range: head {} < start_block {}", head, start_block);
+                    return;
+                }
+            };

-                (current_block - start_block) as f64 / block_difference as f64
+                match current_block.checked_sub(start_block) {
+                    Some(progress) => progress as f64 / block_difference as f64,
+                    None => {
+                        error!("Invalid progress calculation: current {} < start {}", current_block, start_block);
+                        return;
+                    }
+                }

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro