Reviewing files that changed from the base of the PR and between ba21e30 and df0a01f.

• .github/workflows/merge.yaml (3 hunks)
• scripts/download-workflow-binaries.sh (2 hunks)

• GitHub Check: hoprd / docker
• GitHub Check: hopli / docker
• GitHub Check: hoprd-x86_64-darwin / binary
• GitHub Check: hoprd-armv7l-linux / binary
• GitHub Check: hoprd-aarch64-linux / binary
• GitHub Check: hopli-x86_64-linux / binary
• GitHub Check: hoprd-aarch64-darwin / binary
• GitHub Check: hopli-x86_64-darwin / binary
• GitHub Check: hopli-aarch64-linux / binary
• GitHub Check: hopli-armv7l-linux / binary
• GitHub Check: hopli-aarch64-darwin / binary
• GitHub Check: Docs / Rust docs
• GitHub Check: tests-smoke-websocket
• GitHub Check: tests-smart-contracts
• GitHub Check: tests-unit-nightly
• GitHub Check: Linter
• GitHub Check: tests-unit

scripts/download-workflow-binaries.sh (1)

24-25: ⚠️ Potential issue

Fix GitHub API 404 error by verifying the workflow run query.

The script is failing with a GitHub API 404 error. This could be due to:

1. The workflow name has changed from "build.yaml"
2. The branch name format might not match the actual branch name

Let's verify the workflow and branch names:

🧰 Tools

🪛 GitHub Actions: Merge

[error] GitHub API request failed with HTTP 404 (Not Found) error, followed by a JQ parsing error due to null response

.github/workflows/merge.yaml (2)

126-126: Update script call to match new branch naming convention.

The script call assumes a specific branch naming format (bot/close-{PR_NUMBER}), but this might not match the actual branch names used in the repository.

Let's verify the branch naming convention:

✅ Verification successful

Branch naming convention is correctly implemented

The bot/close- prefix is the correct convention for this automated workflow, as evidenced by:

• Usage in multiple workflow files (merge.yaml, close-release.yaml)
• Example in the download script documentation: bot/close-2.2.0-rc.1
• This format is specific to bot operations and doesn't need to match regular PR branch patterns

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify branch naming patterns in recent PRs

echo "Recent PR branch names:"
gh api repos/hoprnet/hoprnet/pulls | jq -r '.[] | [.number, .head.ref] | @tsv' | head -n 5

Length of output: 352

---

Script:

#!/bin/bash
# Check for similar branch naming patterns in workflows and bot configurations
echo "Searching workflow files for branch patterns:"
rg -l "bot/close-" .github/workflows/

echo -e "\nSearching for bot branch naming patterns:"
rg "bot/.*\$.*number" .github/workflows/

echo -e "\nChecking download script content:"
cat scripts/download-workflow-binaries.sh

Length of output: 1714

---

15-16: Verify the impact of adding 'synchronize' trigger.

Adding the 'synchronize' trigger will run this workflow when PRs are updated, not just when they're closed. This could lead to unnecessary workflow runs and potential race conditions.

Let's check the current workflow triggers:

✅ Verification successful

The 'synchronize' trigger is safe to use in this workflow

The workflow has proper safeguards in place:

• Concurrency group prevents parallel runs
• Release job only runs for PRs with 'release' label
• Most jobs are currently disabled during debugging

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check recent workflow runs to verify trigger conditions

echo "Recent workflow runs and their triggers:"
gh api repos/hoprnet/hoprnet/actions/workflows/merge.yaml/runs | jq -r '.workflow_runs[] | select(.conclusion != null) | [.event, .head_branch, .conclusion] | @tsv' | head -n 5

Length of output: 481

---

Script:

#!/bin/bash
# Check the full workflow configuration
echo "Workflow configuration:"
cat .github/workflows/merge.yaml

echo -e "\nOther related workflows:"
fd -e yaml -e yml . .github/workflows/ --exec grep -l "pull_request" {}

Length of output: 11146