Fix ticket deletion check #6762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted the ticket deletion logic in `ticket_manager.rs` to ensure the deleted ticket count is validated correctly, preventing logical errors. Bumped the crate version to 0.11.1 in `Cargo.toml` and `Cargo.lock` to reflect changes. Closes #6761
|
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
db/sql/src/ticket_manager.rs (1)
148-152: Add test coverage for ticket replacement scenarios.While the logic change is sound, it would be beneficial to add test cases that specifically verify:
- Successful replacement when deleted count equals offset
- Successful replacement when deleted count is less than offset
- Error case when deleted count exceeds offset
Would you like me to help generate these test cases?
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
db/sql/Cargo.toml(1 hunks)db/sql/src/ticket_manager.rs(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- db/sql/Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: tests-smoke-websocket
- GitHub Check: tests-unit
- GitHub Check: Linter
🔇 Additional comments (1)
db/sql/src/ticket_manager.rs (1)
148-152: LGTM! The ticket deletion validation logic is now more accurate.The change from equality check to an upper bound check is correct. It properly handles cases where some tickets might have been processed already while preventing over-deletion scenarios.
Let's verify the test coverage for this scenario:
tolbrino
approved these changes
Jan 10, 2025
Teebor-Choka
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted the ticket deletion logic in
ticket_manager.rsto ensure the deleted ticket count is validated correctly, preventing logical errors.Bumped the crate version to 0.11.1 in
Cargo.tomlandCargo.lockto reflect changes.Closes #6761