hoprd/rest-api/src/account.rs (2)

137-148: Add test cases for case-sensitive deserialization

The function correctly handles both "Native" and "NATIVE" cases, improving backwards compatibility. However, the test suite only verifies the "HOPR" case.

Consider adding these test cases to verify all supported formats:

#[test]
fn test_balance_type_deserialization() -> anyhow::Result<()> {
    // Test existing format
    let hopr: WithdrawBodyRequest = serde_json::from_str(r#"{"currency": "HOPR", "amount": "20000", "address": "0xb4ce7e6e36ac8b01a974725d5ba730af2b156fbe"}"#)?;
    assert_eq!(hopr.currency, BalanceType::HOPR);

    // Test both native formats
    let native: WithdrawBodyRequest = serde_json::from_str(r#"{"currency": "Native", "amount": "20000", "address": "0xb4ce7e6e36ac8b01a974725d5ba730af2b156fbe"}"#)?;
    assert_eq!(native.currency, BalanceType::Native);

    let native_upper: WithdrawBodyRequest = serde_json::from_str(r#"{"currency": "NATIVE", "amount": "20000", "address": "0xb4ce7e6e36ac8b01a974725d5ba730af2b156fbe"}"#)?;
    assert_eq!(native_upper.currency, BalanceType::Native);

    // Test error case
    let error = serde_json::from_str::<WithdrawBodyRequest>(r#"{"currency": "invalid", "amount": "20000", "address": "0xb4ce7e6e36ac8b01a974725d5ba730af2b156fbe"}"#);
    assert!(error.is_err());

    Ok(())
}

---

159-160: Update schema example to document all supported formats

The schema example only shows one format ("HOPR"), but the API now supports multiple formats for the currency field ("Native"/"NATIVE").

Update the schema example to document all supported formats:

 #[schema(example = json!({
         "address": "0xb4ce7e6e36ac8b01a974725d5ba730af2b156fbe",
         "amount": "20000",
-        "currency": "HOPR"
+        "currency": "HOPR"  // Supported values: "HOPR", "Native", "NATIVE"
     }))]

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

#!/bin/bash
# Search for withdraw endpoint usage in tests and examples
rg -A 2 -B 2 'currency.*(?:NATIVE|Native|HOPR)' --type rust

# Search for any HTTP client implementations that might be using the endpoint
rg -A 5 '/account/withdraw' --type typescript --type javascript --type python

#!/bin/bash
# Let's search for test files and client implementations with more inclusive patterns
rg -A 5 "withdraw" --type rust

# Search for any HTTP client implementations with proper file extensions
rg -A 5 '/account/withdraw' -g '*.ts' -g '*.js' -g '*.py'

# Look for API tests specifically
fd -e test.ts -e test.js -e test.py -e test.rs | xargs rg -l "withdraw"

# Check for any OpenAPI/Swagger definitions that might document the endpoint
fd -e yaml -e json | xargs rg -l "withdraw"

#!/bin/bash
# Let's check for test files that specifically test the withdraw endpoint
rg -A 5 -B 5 "test.*withdraw" tests/

# Look for any Python client usage of the withdraw endpoint
rg -A 5 "withdraw" tests/hopr.py

# Check for any API documentation or OpenAPI specs
fd -e yaml -e json | xargs rg -A 5 "/account/withdraw"

hoprd/rest-api/src/account.rs (1)

Line range hint 223-242: Add test cases for backwards compatibility

The current test only covers the "HOPR" case. To ensure backwards compatibility, we should add test cases for both "Native" and "NATIVE" variants.

Add these test cases:

#[test]
fn withdraw_input_should_support_native_variants() -> anyhow::Result<()> {
    // Test lowercase "Native"
    let native: WithdrawBodyRequest = serde_json::from_str(
        r#"{
        "currency": "Native",
        "amount": "20000",
        "address": "0xb4ce7e6e36ac8b01a974725d5ba730af2b156fbe"}"#,
    )?;
    assert_eq!(native.currency, BalanceType::Native);

    // Test uppercase "NATIVE"
    let NATIVE: WithdrawBodyRequest = serde_json::from_str(
        r#"{
        "currency": "NATIVE",
        "amount": "20000",
        "address": "0xb4ce7e6e36ac8b01a974725d5ba730af2b156fbe"}"#,
    )?;
    assert_eq!(NATIVE.currency, BalanceType::Native);

    Ok(())
}

hoprd/rest-api/src/account.rs (2)

143-147: Improve error message for invalid balance types

The error message for invalid balance types could be more helpful by listing the supported values.

-        _ => Err(serde::de::Error::custom("Unsupported balance type")),
+        _ => Err(serde::de::Error::custom("Unsupported balance type. Expected 'Native', 'NATIVE', or 'HOPR'")),

---

159-160: Remove commented-out code

The old implementation using DisplayFromStr should be removed rather than commented out, as it's being replaced by the new deserialization approach.

-    // #[serde_as(as = "DisplayFromStr")]
     #[serde(deserialize_with = "deserialize_balance_type")]

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

#!/bin/bash
# Search for potential currency field usages that might need similar handling
rg -l 'currency.*BalanceType' --type rust

# Search for similar struct definitions that might need the same treatment
ast-grep --pattern 'struct $_ {
  $$$
  currency: BalanceType,
  $$$
}'

#!/bin/bash
# Search for all BalanceType usages and their context
rg -A 5 -B 5 'BalanceType' --type rust

# Search for any serialization/deserialization of BalanceType
ast-grep --pattern 'impl $_ for BalanceType'