Update the logging to remove the offline peer error on heartbeat #6680
Conversation
📝 WalkthroughWalkthroughThe changes in this pull request focus on enhancing error handling within the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
transport/p2p/src/swarm.rs (2)
484-488: LGTM! Error handling improvement aligns with PR objectives.The changes correctly implement the desired behavior by:
- Distinguishing between dial failures (offline peers) and other outbound failures
- Using appropriate log levels (trace for expected offline peers, error for unexpected failures)
However, consider adding a debug log for offline peers instead of trace, as this information might be useful for debugging connection issues:
-trace!(%peer, %request_id, %error, "Peer is offline"); +debug!(%peer, %request_id, %error, "Peer is offline");
482-483: Consider adding error handling for cache invalidation.The
active_pings.invalidate(&request_id).awaitoperation should be checked for errors to ensure proper cleanup of resources.-active_pings.invalidate(&request_id).await; +if let Err(e) = active_pings.invalidate(&request_id).await { + warn!(%peer, %request_id, error = %e, "Failed to invalidate active ping"); +}
The error on dialing for offline peers was expected in the heartbeat protocol and should not be a reason for error log.
This should clean the logs up significantly.