Skip to content

Use the quic-v1 multiaddress as a default for announcement #6607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

Teebor-Choka
Copy link
Contributor

Use the QUIC transport on the libp2p layer by default:

  1. announce a quic-v1 multiaddress
  2. be reachable by TCP and have TCP transport for backwards compatibility

@Teebor-Choka Teebor-Choka added this to the 2.2.0-rc.1 milestone Nov 6, 2024
@Teebor-Choka Teebor-Choka self-assigned this Nov 6, 2024
Copy link
Contributor

coderabbitai bot commented Nov 6, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The Cargo.toml file for the hoprd package has been updated to include a new feature named transport-quic. This feature has been added to the default feature list, meaning it will be enabled by default. The transport-quic feature depends on the hopr-lib/transport-quic component, with no other changes made to existing features or configurations.

Changes

File Change Summary
hoprd/hoprd/Cargo.toml Added transport-quic feature to [features] section and included it in the default feature list.

Possibly related PRs

Suggested labels

crate:hopr-lib, crate:core-transport

Suggested reviewers

  • tolbrino

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 43dd673 and 0c91503.

📒 Files selected for processing (1)
  • hoprd/hoprd/Cargo.toml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • hoprd/hoprd/Cargo.toml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Teebor-Choka Teebor-Choka requested a review from a team November 6, 2024 22:03
@Teebor-Choka Teebor-Choka marked this pull request as ready for review November 6, 2024 22:03
@github-actions github-actions bot added dependencies Pull requests that update a dependency file crate:hoprd labels Nov 6, 2024
@Teebor-Choka Teebor-Choka changed the title Use the quic-v1 libp2p transport by default Use the quic-v1 libp2p address as a default for announcement Nov 6, 2024
@Teebor-Choka Teebor-Choka changed the title Use the quic-v1 libp2p address as a default for announcement Use the quic-v1 multiaddress as a default for announcement Nov 6, 2024
@Teebor-Choka Teebor-Choka merged commit 1d90958 into master Nov 7, 2024
27 of 28 checks passed
@Teebor-Choka Teebor-Choka deleted the kauki/libp2p/announce-as-quic-v1 branch November 7, 2024 09:28
@coderabbitai coderabbitai bot mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate:hoprd dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant