Skip to content

Add HTTPS server communication tests #6500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2024
Merged

Add HTTPS server communication tests #6500

merged 2 commits into from
Sep 19, 2024

Conversation

NumberFour8
Copy link
Contributor

Added tests for session communication with HTTPS servers, including self-signed certificate generation and retrieval of random text files. Updated test requirements to include the cryptography library, and improved existing tests by filtering out empty messages.

@NumberFour8
Add HTTPS server communication tests
310ee20 
Added tests for session communication with HTTPS servers, including self-signed certificate generation and retrieval of random text files. Updated test requirements to include the `cryptography` library, and improved existing tests by filtering out empty messages.
@NumberFour8 NumberFour8 self-assigned this Sep 19, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 19, 2024 •
edited
Loading

Walkthrough

Walkthrough

The pull request introduces a new dependency, cryptography==43.0.1, to the testing environment, enhancing the capability to test secure communications. It also adds new functionalities to tests/test_session.py, including HTTPS server testing, with helper functions for fetching files and generating self-signed certificates. The existing TCP and UDP echo server tests are modified to improve data handling, ensuring the tests cover the new HTTPS functionality while maintaining the integrity of previous tests.

Changes

Files Change Summary
tests/requirements.txt Added cryptography==43.0.1 to enhance testing capabilities for secure data handling.
tests/test_session.py Introduced new functions for HTTPS testing and modified existing echo server tests to improve data handling.
Added helper functions: fetch_random_local_text_file and generate_self_signed_cert.
Implemented context manager run_https_server for setting up an HTTPS server.
Added tests: test_session_communication_with_an_https_server and test_session_communication_over_n_hop_with_an_https_server.

Possibly related PRs

  • Session improvements #6481: Enhances session management and introduces functionalities that may relate to the testing of secure communication.
  • Fix failing unit tests #6492: Focuses on fixing unit tests, which could indirectly relate to the changes in tests/test_session.py involving testing functionalities.

Suggested labels

crate:hoprd-api

Suggested reviewers

  • QYuQianchen
  • Teebor-Choka

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the testing Related to tests label Sep 19, 2024
Teebor-Choka
Teebor-Choka approved these changes Sep 19, 2024
View reviewed changes
@NumberFour8
Refactor HTTPS server setup in tests.
94bf101 
Introduce threading and updated SSL context for the HTTPS server in test_session.py. This change ensures the server runs in a separate thread and adds an artificial delay to handler responses, enhancing test realism and stability.
@NumberFour8 NumberFour8 marked this pull request as ready for review September 19, 2024 15:53
coderabbitai[bot]
coderabbitai bot reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 2046109 and 94bf101.

Files selected for processing (2)
  • tests/requirements.txt (1 hunks)
  • tests/test_session.py (6 hunks)
Additional context used
Ruff
tests/test_session.py

464-464: Line too long (126 > 120)

(E501)

502-502: Line too long (129 > 120)

(E501)

511-511: Line too long (130 > 120)

(E501)

Additional comments not posted (1)
tests/requirements.txt (1)

2-2: LGTM! The addition of the cryptography package aligns with the PR objectives.

The inclusion of the cryptography package at version 43.0.1 is a positive change that enables testing of components involving cryptographic operations. This aligns well with the PR objectives of introducing tests for HTTPS server communication, as cryptography is essential for secure communication.

Specifying the exact version of the package is a good practice to ensure consistent behavior across different testing environments.

@NumberFour8 NumberFour8 merged commit fc1c499 into master Sep 19, 2024
1 check passed
@NumberFour8 NumberFour8 deleted the lukas/add-session-tls-tests branch September 19, 2024 19:08
This was referenced Sep 20, 2024
Merged
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Oct 1, 2024
Merged
This was referenced Oct 15, 2024
Merged
Merged
This was referenced Nov 2, 2024
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Jul 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@Teebor-Choka Teebor-Choka Teebor-Choka approved these changes

Assignees

@NumberFour8 NumberFour8

Labels
testing Related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NumberFour8 @Teebor-Choka