Make Ledger properties public #5631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@QYuQianchen This would need to go into the dedicated SC development branch. |
Is there such a branch? |
|
This is indeed a bug. Not having the latest roots as public properties unfortunately makes it necessary to read from storage - which makes its usage unnessarily complex. On the other hand, the versions in the monorepo allow a proper local setup using Foundry of the current version of the smart contracts. Changes to the contracts will deviate from the deployed versions and can lead to unforeseen regressions when testing. |
17 tasks
QYuQianchen
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.