Skip to content

ensureNodeIsSafeModuleMember returns early when there are multiple node management modules attached to the safe #6466

@QYuQianchen

Description

@QYuQianchen

Description

Function ensureNodeIsSafeModuleMember go through a linked list to find the "first" module address that fulfils the check:

IHoprNodeManagementModule(modules[i]).isHoprNodeManagementModule() &&
 IHoprNodeManagementModule(modules[i]).isNode(nodeChainKeyAddress)

This is undesirable when multiple modules are attached to the Safe.

Metadata

Metadata

Assignees

Type

Projects

Status

Backlog

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions