Skip to content

Improve owner-swap in Safe instantiation in NodeSafeFactory #5528

@QYuQianchen

Description

@QYuQianchen
  • Add a revert. When instantiating a Safe proxy, NodeSafeFactory should check that the provided admins doesn't contain the NodeSafeFactory itself.
  • When instantiating a Safe proxy, NodeSafeFactory should append itself as admins (which eventually becomes owners of Safe proxy) and then remove itself. This makes safeInitializer different in each clone transaction and thus becomes another source of entropy besides nonce.

Metadata

Metadata

Assignees

Type

No type

Projects

Status

To triage

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions