Description

This is a tracker issue for all the changes in smart contract to be included after Aug audit.

After deciding on keeping the on-chain network the same for v3.0 release, post-providence smart contract issues are separated into v3.0 and v4.0

General

• Consider using Ownership2Step (TicketPriceOracle.sol, StakingProxyForNetworkRegistry.sol)
• Use HoprLedger in all the contracts that are indexed by the hoprd indexer

Channels.sol

• Testing: As mentioned in Smart contract audit tracker #5278, add fuzz-tests in ticket-redemption. "turn the aggregation test into a "full fuzzy test" which might reveal additional shortcomings but that can be left as an afterwork exercise"
• Include channel epoch in computing channel ID hash #5597
• use packet encoding for tickets (intended, but currently broken)
• Make Ledger properties public #5631
• Correct INDEX_SNAPSHOT_INTERVAL to seconds
• Time units are better and precise to use hats-finance/SafeStaking-by-HOPR-0x607386df18b663cf5ee9b879fbc1f32466ad5a85#34
• Constructor lacking address(0) check hats-finance/SafeStaking-by-HOPR-0x607386df18b663cf5ee9b879fbc1f32466ad5a85#35
• Improve code comments on:
  • Token transfers are allowed in with PENDING_TO_CLOSE as part of redeemTicket action
  • The MAX_USED_BALANCE check applies to the increment but not the final channel balance.
• Consider allowing batch action e.g. closing multiple channels

NetworkRegistryProxy.sol

• Handle "div0" when self-registration is not enabled.

NetworkRegistry.sol

• Handle the case when self-registration is not enabled.

Announcements.sol

• Constructor lacking address(0) check hats-finance/SafeStaking-by-HOPR-0x607386df18b663cf5ee9b879fbc1f32466ad5a85#35

Ledger.sol

• Constructor lacks zero value check hats-finance/SafeStaking-by-HOPR-0x607386df18b663cf5ee9b879fbc1f32466ad5a85#36

Crypto.sol

• Non zeroed memory region can cause incorrect hash #6461

NodeSafeFactory.sol

• Reduce unnecessary Safe tx calls in NodeStakeFactory #5527
• Improve owner-swap in Safe instantiation in NodeSafeFactory #5528
• Enhance Flexibility: NodeSafeFactory Contracts and Safe Compatibility #5532
• Expose channelId as part of the ChannelOpened event on-chain #5635
• In place of MultiSendCallOnly, use MultiSend
• Rename event from "DergisteredNodeSafe" to "DeregisteredNodeSafe"

NodeStakeFactory.sol

• Possible to front-run safe setup and inject malicious module hats-finance/SafeStaking-by-HOPR-0x607386df18b663cf5ee9b879fbc1f32466ad5a85#22
• Problems with ensureNodeIsSafeModuleMember() hats-finance/SafeStaking-by-HOPR-0x607386df18b663cf5ee9b879fbc1f32466ad5a85#23
• ensureNodeIsSafeModuleMember returns early when there are multiple node management modules attached to the safe #6466

Others

• Review and evaluate GnosisGuild's Roles v2 implementation

Definition of DONE

• Fix reported issues
• Improve gas usage